larryh/corso
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Temporary removal of OneNote file size check (#4437)

Browse Source 
Temporarily remove the large file size check that controls skipping a OneNote file download that failed with a
503 error.

We've observed this error condition to be persistent even with smaller OneNote files.

This allows us to unblock backup for these resources while we investigate the issue.

---

#### Does this PR need a docs update or release note?

- [x] ✅ Yes, it's included
- [ ] 🕐 Yes, but in a later PR
- [ ] ⛔ No

#### Type of change

<!--- Please check the type of change your PR introduces: --->
- [ ] 🌻 Feature
- [x] 🐛 Bugfix
- [ ] 🗺️ Documentation
- [ ] 🤖 Supportability/Tests
- [ ] 💻 CI/Deployment
- [ ] 🧹 Tech Debt/Cleanup

#### Issue(s)

<!-- Can reference multiple issues. Use one of the following "magic words" - "closes, fixes" to auto-close the Github issue. -->
* #<issue>

#### Test Plan

<!-- How will this be tested prior to merging.-->
- [x] 💪 Manual
- [ ] ⚡ Unit test
- [ ] 💚 E2E
This commit is contained in:
Vaibhav Kamra 2023-10-04 22:19:30 -07:00 committed by GitHub
parent fd3a4eb6ff
commit 02db885c1e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/internal/m365/collection/drive/collection.go
View File

@ -265,7 +265,10 @@ func (oc *Collection) getDriveItemContent(
// Skip big OneNote files as they can't be downloaded // Skip big OneNote files as they can't be downloaded
if clues.HasLabel(err, graph.LabelStatus(http.StatusServiceUnavailable)) && if clues.HasLabel(err, graph.LabelStatus(http.StatusServiceUnavailable)) &&
oc.scope == CollectionScopePackage && *item.GetSize() >= MaxOneNoteFileSize { // TODO: We've removed the file size check because it looks like we've seen persistent
// 503's with smaller OneNote files also.
// oc.scope == CollectionScopePackage && *item.GetSize() >= MaxOneNoteFileSize {
oc.scope == CollectionScopePackage {
// FIXME: It is possible that in case of a OneNote file we // FIXME: It is possible that in case of a OneNote file we
// will end up just backing up the `onetoc2` file without // will end up just backing up the `onetoc2` file without
// the one file which is the important part of the OneNote // the one file which is the important part of the OneNote

2
src/internal/m365/collection/drive/collection_test.go
View File

@ -565,7 +565,7 @@ func (suite *GetDriveItemUnitTestSuite) TestGetDriveItem_error() {
colScope: CollectionScopePackage, colScope: CollectionScopePackage,
itemSize: 10, itemSize: 10,
err: clues.New("small onenote error").Label(graph.LabelStatus(http.StatusServiceUnavailable)), err: clues.New("small onenote error").Label(graph.LabelStatus(http.StatusServiceUnavailable)),
labels: []string{graph.LabelStatus(http.StatusServiceUnavailable)}, labels: []string{graph.LabelStatus(http.StatusServiceUnavailable), graph.LabelsSkippable},
}, },
{ {
name: "big OneNote file", name: "big OneNote file",