diff --git a/src/internal/common/buckets_test.go b/src/internal/common/buckets_test.go index c8c6ee762..e3263d7e8 100644 --- a/src/internal/common/buckets_test.go +++ b/src/internal/common/buckets_test.go @@ -7,14 +7,16 @@ import ( "github.com/stretchr/testify/suite" "github.com/alcionai/corso/src/internal/common" + "github.com/alcionai/corso/src/internal/tester" ) type CommonBucketsSuite struct { - suite.Suite + tester.Suite } func TestCommonBucketsSuite(t *testing.T) { - suite.Run(t, new(CommonBucketsSuite)) + s := &CommonBucketsSuite{Suite: tester.NewUnitSuite(t)} + suite.Run(t, s) } func (suite *CommonBucketsSuite) TestBucketPrefix() { diff --git a/src/internal/common/configs_test.go b/src/internal/common/configs_test.go index e59b98d08..5142beb72 100644 --- a/src/internal/common/configs_test.go +++ b/src/internal/common/configs_test.go @@ -7,14 +7,16 @@ import ( "github.com/stretchr/testify/suite" "github.com/alcionai/corso/src/internal/common" + "github.com/alcionai/corso/src/internal/tester" ) type CommonConfigsSuite struct { - suite.Suite + tester.Suite } func TestCommonConfigsSuite(t *testing.T) { - suite.Run(t, new(CommonConfigsSuite)) + s := &CommonConfigsSuite{Suite: tester.NewUnitSuite(t)} + suite.Run(t, s) } const ( @@ -52,7 +54,9 @@ func (suite *CommonConfigsSuite) TestUnionConfigs_string() { {"fc error", stringConfig{keyExpect, nil}, stringConfig2{keyExpect2, assert.AnError}, assert.Error}, } for _, test := range table { - suite.T().Run(test.name, func(t *testing.T) { + suite.Run(test.name, func() { + t := suite.T() + cs, err := common.UnionStringConfigs(test.ac, test.bc) test.errCheck(t, err) // remaining tests depend on error-free state diff --git a/src/internal/common/errors_test.go b/src/internal/common/errors_test.go index 0cb0ca048..767f1515b 100644 --- a/src/internal/common/errors_test.go +++ b/src/internal/common/errors_test.go @@ -9,6 +9,7 @@ import ( "github.com/stretchr/testify/suite" "github.com/alcionai/corso/src/internal/common" + "github.com/alcionai/corso/src/internal/tester" ) type testErr struct { @@ -20,11 +21,12 @@ type testErr2 struct { } type ErrorsUnitSuite struct { - suite.Suite + tester.Suite } func TestErrorsUnitSuite(t *testing.T) { - suite.Run(t, new(ErrorsUnitSuite)) + s := &ErrorsUnitSuite{Suite: tester.NewUnitSuite(t)} + suite.Run(t, s) } func (suite *ErrorsUnitSuite) TestPropagatesCause() { diff --git a/src/internal/common/ptr/pointer_test.go b/src/internal/common/ptr/pointer_test.go index 9cf24c5cb..528c866f4 100644 --- a/src/internal/common/ptr/pointer_test.go +++ b/src/internal/common/ptr/pointer_test.go @@ -8,14 +8,16 @@ import ( "github.com/stretchr/testify/suite" "github.com/alcionai/corso/src/internal/common/ptr" + "github.com/alcionai/corso/src/internal/tester" ) type PointerSuite struct { - suite.Suite + tester.Suite } func TestPointerSuite(t *testing.T) { - suite.Run(t, new(PointerSuite)) + s := &PointerSuite{Suite: tester.NewUnitSuite(t)} + suite.Run(t, s) } // TestVal checks to ptr derefencing for the diff --git a/src/internal/common/slices_test.go b/src/internal/common/slices_test.go index 534b573a0..9aae236a5 100644 --- a/src/internal/common/slices_test.go +++ b/src/internal/common/slices_test.go @@ -7,14 +7,16 @@ import ( "github.com/stretchr/testify/suite" "github.com/alcionai/corso/src/internal/common" + "github.com/alcionai/corso/src/internal/tester" ) type CommonSlicesSuite struct { - suite.Suite + tester.Suite } func TestCommonSlicesSuite(t *testing.T) { - suite.Run(t, new(CommonSlicesSuite)) + s := &CommonSlicesSuite{Suite: tester.NewUnitSuite(t)} + suite.Run(t, s) } func (suite *CommonSlicesSuite) TestContainsString() { diff --git a/src/internal/common/time_test.go b/src/internal/common/time_test.go index 6d72b0e19..5303db875 100644 --- a/src/internal/common/time_test.go +++ b/src/internal/common/time_test.go @@ -9,14 +9,16 @@ import ( "github.com/stretchr/testify/suite" "github.com/alcionai/corso/src/internal/common" + "github.com/alcionai/corso/src/internal/tester" ) type CommonTimeUnitSuite struct { - suite.Suite + tester.Suite } func TestCommonTimeUnitSuite(t *testing.T) { - suite.Run(t, new(CommonTimeUnitSuite)) + s := &CommonTimeUnitSuite{Suite: tester.NewUnitSuite(t)} + suite.Run(t, s) } func (suite *CommonTimeUnitSuite) TestFormatTime() { @@ -145,7 +147,9 @@ func (suite *CommonTimeUnitSuite) TestExtractTime() { } for _, test := range table { - suite.T().Run(test.input, func(t *testing.T) { + suite.Run(test.input, func() { + t := suite.T() + result, err := common.ExtractTime(test.input) require.NoError(t, err) assert.Equal(t, test.expect, comparable(t, result, test.clippedFormat))