From 046a471077dfe23b9f0654941310b2c667c8ecae Mon Sep 17 00:00:00 2001 From: ashmrtn <3891298+ashmrtn@users.noreply.github.com> Date: Wed, 26 Jul 2023 15:15:37 -0700 Subject: [PATCH] Delete details snapshot (#3914) Check for a populated StreamStoreID and fallback to the DetailsID if necessary. --- #### Does this PR need a docs update or release note? - [ ] :white_check_mark: Yes, it's included - [ ] :clock1: Yes, but in a later PR - [x] :no_entry: No #### Type of change - [ ] :sunflower: Feature - [x] :bug: Bugfix - [ ] :world_map: Documentation - [ ] :robot: Supportability/Tests - [ ] :computer: CI/Deployment - [ ] :broom: Tech Debt/Cleanup #### Issue(s) * closes #3913 #### Test Plan - [x] :muscle: Manual - [ ] :zap: Unit test - [ ] :green_heart: E2E --- src/pkg/repository/repository.go | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/pkg/repository/repository.go b/src/pkg/repository/repository.go index b26a6a2ef..1417d872d 100644 --- a/src/pkg/repository/repository.go +++ b/src/pkg/repository/repository.go @@ -616,8 +616,13 @@ func deleteBackup( } } - if len(b.DetailsID) > 0 { - if err := kw.DeleteSnapshot(ctx, b.DetailsID); err != nil { + ssid := b.StreamStoreID + if len(ssid) == 0 { + ssid = b.DetailsID + } + + if len(ssid) > 0 { + if err := kw.DeleteSnapshot(ctx, ssid); err != nil { return err } }