From 0df876d1068cec6c8fe308e4fe89ac456eda586a Mon Sep 17 00:00:00 2001 From: ashmrtn <3891298+ashmrtn@users.noreply.github.com> Date: Mon, 25 Sep 2023 15:23:15 -0700 Subject: [PATCH] Disable Exchange kopia assisted incrementals (#4360) Can be reenabled when we get a good solution to deletion markers for individual items. --- #### Does this PR need a docs update or release note? - [ ] :white_check_mark: Yes, it's included - [ ] :clock1: Yes, but in a later PR - [x] :no_entry: No #### Type of change - [ ] :sunflower: Feature - [x] :bug: Bugfix - [ ] :world_map: Documentation - [ ] :robot: Supportability/Tests - [ ] :computer: CI/Deployment - [ ] :broom: Tech Debt/Cleanup #### Issue(s) * #2023 #### Test Plan - [ ] :muscle: Manual - [x] :zap: Unit test - [x] :green_heart: E2E --- src/internal/m365/collection/exchange/backup.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/internal/m365/collection/exchange/backup.go b/src/internal/m365/collection/exchange/backup.go index 87db96312..48193f89b 100644 --- a/src/internal/m365/collection/exchange/backup.go +++ b/src/internal/m365/collection/exchange/backup.go @@ -160,7 +160,7 @@ func populateCollections( ictx = clues.Add(ictx, "previous_path", prevPath) - added, validModTimes, removed, newDelta, err := bh.itemEnumerator(). + added, _, removed, newDelta, err := bh.itemEnumerator(). GetAddedAndRemovedItemIDs( ictx, qp.ProtectedResource.ID(), @@ -199,7 +199,9 @@ func populateCollections( bh.itemHandler(), added, removed, - validModTimes, + // TODO(ashmrtn): Set to value returned by pager when we have deletion + // markers in files. + false, statusUpdater) collections[cID] = edc