From 15e396ca92f6b07ac5f4225df00a76ffb7333205 Mon Sep 17 00:00:00 2001
From: Abhishek Pandey <abhishek@alcion.ai>
Date: Tue, 10 Oct 2023 17:04:27 +0530
Subject: [PATCH] Move code around

---
 src/internal/m365/graph/middleware.go |  6 ------
 src/internal/operations/backup.go     |  4 ++--
 src/internal/operations/common.go     | 11 +++++++++++
 src/internal/stats/stats.go           | 14 +-------------
 4 files changed, 14 insertions(+), 21 deletions(-)

diff --git a/src/internal/m365/graph/middleware.go b/src/internal/m365/graph/middleware.go
index 4adf8cef8..d5935a5b0 100644
--- a/src/internal/m365/graph/middleware.go
+++ b/src/internal/m365/graph/middleware.go
@@ -6,7 +6,6 @@ import (
 	"net/http"
 	"strconv"
 	"strings"
-	"sync/atomic"
 	"time"
 
 	"github.com/alcionai/clues"
@@ -326,8 +325,6 @@ func (mw RetryMiddleware) getRetryDelay(
 // MetricsMiddleware aggregates per-request metrics on the events bus
 type MetricsMiddleware struct{}
 
-var xmCount int64
-
 const xmruHeader = "x-ms-resource-unit"
 
 func (mw *MetricsMiddleware) Intercept(
@@ -365,9 +362,6 @@ func (mw *MetricsMiddleware) Intercept(
 		xmrui = 1
 	}
 
-	atomic.AddInt64(&xmCount, int64(xmrui))
-	logger.Ctx(req.Context()).Info("xmcount ", xmCount)
-
 	countBus := count.Ctx(req.Context())
 	countBus.Add(count.APICallTokensConsumed, int64(xmrui))
 
diff --git a/src/internal/operations/backup.go b/src/internal/operations/backup.go
index e9bfc7021..880ee2b91 100644
--- a/src/internal/operations/backup.go
+++ b/src/internal/operations/backup.go
@@ -848,8 +848,8 @@ func (op *BackupOperation) persistResults(
 	op.Results.ItemsRead = opStats.ctrl.Successes
 
 	// API stats
-	apiStats := stats.GetAPIStats(op.Counter)
-	op.Results.TokensConsumed = apiStats.TokensConsumed
+	apiStats := getAPIStats(op.Counter)
+	op.Results.APITokensConsumed = apiStats.APITokensConsumed
 
 	// Only return non-recoverable errors at this point.
 	return op.Errors.Failure()
diff --git a/src/internal/operations/common.go b/src/internal/operations/common.go
index 023631dc7..016a49ce4 100644
--- a/src/internal/operations/common.go
+++ b/src/internal/operations/common.go
@@ -6,9 +6,11 @@ import (
 	"github.com/alcionai/clues"
 
 	"github.com/alcionai/corso/src/internal/model"
+	"github.com/alcionai/corso/src/internal/stats"
 	"github.com/alcionai/corso/src/internal/streamstore"
 	"github.com/alcionai/corso/src/pkg/backup"
 	"github.com/alcionai/corso/src/pkg/backup/details"
+	"github.com/alcionai/corso/src/pkg/count"
 	"github.com/alcionai/corso/src/pkg/fault"
 	"github.com/alcionai/corso/src/pkg/store"
 )
@@ -59,3 +61,12 @@ func getDetailsFromBackup(
 
 	return &deets, nil
 }
+
+func getAPIStats(
+	ctr *count.Bus,
+) stats.APIStats {
+	s := stats.APIStats{}
+	s.APITokensConsumed = ctr.Total(count.APICallTokensConsumed)
+
+	return s
+}
diff --git a/src/internal/stats/stats.go b/src/internal/stats/stats.go
index 187984d31..4e9b442fe 100644
--- a/src/internal/stats/stats.go
+++ b/src/internal/stats/stats.go
@@ -3,8 +3,6 @@ package stats
 import (
 	"sync/atomic"
 	"time"
-
-	"github.com/alcionai/corso/src/pkg/count"
 )
 
 // ReadWrites tracks the total count of reads and writes.  ItemsRead
@@ -47,15 +45,5 @@ type SkippedCounts struct {
 }
 
 type APIStats struct {
-	TokensConsumed int64 `json:"tokensConsumed"`
-}
-
-func GetAPIStats(
-	ctr *count.Bus,
-) APIStats {
-	s := APIStats{}
-
-	s.TokensConsumed = ctr.Total(count.APICallTokensConsumed)
-
-	return s
+	APITokensConsumed int64 `json:"apiTokensConsumed"`
 }