larryh/corso
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

revert DPanic log to Error in support pkg (#1340)

Browse Source 
## Description

The panic in development mode is interfering with test scrutiny and other general behavior.  Errors will be reported naturally without the need for this additional panic.

## Type of change

- [x] 🤖 Test
- [x] 🐹 Trivial/Minor

## Issue(s)

* #902

## Test Plan

- [x] 💚 E2E
This commit is contained in:
Keepers 2022-10-28 07:32:47 -06:00 committed by GitHub
parent 8900f6dff9
commit 2a2af20f94
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/internal/connector/support/status.go
View File

@ -77,12 +77,12 @@ func CreateStatus(
} }
if status.ObjectCount != status.errorCount+status.Successful { if status.ObjectCount != status.errorCount+status.Successful {
logger.Ctx(ctx).DPanicw( logger.Ctx(ctx).Errorw(
"status object count does not match errors + successes", "status object count does not match errors + successes",
"objects", cm.Objects, "objects", cm.Objects,
"successes", cm.Successes, "successes", cm.Successes,
"numErrors", numErr, "numErrors", numErr,
"errors", err.Error()) "errors", err)
} }
return &status return &status

2
src/internal/connector/support/status_test.go
View File

@ -72,7 +72,7 @@ func (suite *GCStatusTestSuite) TestCreateStatus_InvalidStatus() {
t := suite.T() t := suite.T()
params := statusParams{Backup, 9, 3, 13, errors.New("invalidcl")} params := statusParams{Backup, 9, 3, 13, errors.New("invalidcl")}
require.Panics(t, func() { require.NotPanics(t, func() {
ctx, flush := tester.NewContext() ctx, flush := tester.NewContext()
defer flush() defer flush()