From 2cd73e2d9177471b3cbf966e0e7589b0fe58d619 Mon Sep 17 00:00:00 2001
From: Abhishek Pandey <abhishek@alcion.ai>
Date: Mon, 4 Dec 2023 10:07:35 -0800
Subject: [PATCH] Remove sharepointids from delta query $select params (#4748)

<!-- PR description-->

We are not making use of `GetSharepointIds()` anymore. It was removed a month back, see [PR](https://github.com/alcionai/corso/pull/4436/files#diff-fc955b9b2e400cdda711ab2b6bf459845369691c5abc3973bbfaa1c83a664688L43). So we don't need to fetch this per item-property from graph during delta queries.

This will reduce overall mem usage since we don't need to store references to the sharepoint id map. It can also make delta queries go slightly faster since we are transferring & processing fewer bytes over network.

---

#### Does this PR need a docs update or release note?

- [ ] :white_check_mark: Yes, it's included
- [ ] :clock1: Yes, but in a later PR
- [x] :no_entry: No

#### Type of change

<!--- Please check the type of change your PR introduces: --->
- [ ] :sunflower: Feature
- [ ] :bug: Bugfix
- [ ] :world_map: Documentation
- [ ] :robot: Supportability/Tests
- [ ] :computer: CI/Deployment
- [x] :broom: Tech Debt/Cleanup

#### Issue(s)

<!-- Can reference multiple issues. Use one of the following "magic words" - "closes, fixes" to auto-close the Github issue. -->
* #<issue>

#### Test Plan

<!-- How will this be tested prior to merging.-->
- [x] :muscle: Manual
- [x] :zap: Unit test
- [ ] :green_heart: E2E
---
 src/pkg/services/m365/api/config.go           | 1 -
 src/pkg/services/m365/api/drive_pager_test.go | 1 -
 2 files changed, 2 deletions(-)

diff --git a/src/pkg/services/m365/api/config.go b/src/pkg/services/m365/api/config.go
index a2bc39cdd..50453c81e 100644
--- a/src/pkg/services/m365/api/config.go
+++ b/src/pkg/services/m365/api/config.go
@@ -117,7 +117,6 @@ func DefaultDriveItemProps() []string {
 		"package",
 		"parentReference",
 		"root",
-		"sharepointIds",
 		"size",
 		"deleted",
 		"malware",
diff --git a/src/pkg/services/m365/api/drive_pager_test.go b/src/pkg/services/m365/api/drive_pager_test.go
index 3f52f1518..417c8f5df 100644
--- a/src/pkg/services/m365/api/drive_pager_test.go
+++ b/src/pkg/services/m365/api/drive_pager_test.go
@@ -273,7 +273,6 @@ func (suite *DrivePagerIntgSuite) TestDriveDeltaPagerQueryParams() {
 					"package",
 					"parentReference",
 					"root",
-					"sharepointIds",
 					"size",
 					"deleted",
 					"malware",