From 39428a4b4130acb609385d3a2f620f1bed485cec Mon Sep 17 00:00:00 2001 From: Abin Simon Date: Tue, 12 Sep 2023 08:51:19 +0530 Subject: [PATCH] Switch to using BuildMetadata helper (#4217) --- #### Does this PR need a docs update or release note? - [ ] :white_check_mark: Yes, it's included - [ ] :clock1: Yes, but in a later PR - [x] :no_entry: No #### Type of change - [ ] :sunflower: Feature - [ ] :bug: Bugfix - [ ] :world_map: Documentation - [ ] :robot: Supportability/Tests - [ ] :computer: CI/Deployment - [x] :broom: Tech Debt/Cleanup #### Issue(s) * # #### Test Plan - [ ] :muscle: Manual - [ ] :zap: Unit test - [ ] :green_heart: E2E --- src/internal/m365/backup_test.go | 4 +--- src/internal/m365/service/groups/backup.go | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/src/internal/m365/backup_test.go b/src/internal/m365/backup_test.go index a712a3254..46c1cbfa4 100644 --- a/src/internal/m365/backup_test.go +++ b/src/internal/m365/backup_test.go @@ -543,9 +543,7 @@ func (suite *GroupsCollectionIntgSuite) TestCreateGroupsCollection_SharePoint() // but it should be more than one. assert.Greater(t, len(collections), 1) - // TODO(meain): Switch to using BuildMetadata - // https://github.com/alcionai/corso/pull/4184#discussion_r1316139701 - p, err := path.Builder{}.ToServiceCategoryMetadataPath( + p, err := path.BuildMetadata( suite.tenantID, groupID, path.GroupsService, diff --git a/src/internal/m365/service/groups/backup.go b/src/internal/m365/service/groups/backup.go index b38a5d684..1a86161a6 100644 --- a/src/internal/m365/service/groups/backup.go +++ b/src/internal/m365/service/groups/backup.go @@ -187,9 +187,7 @@ func getSitesMetadataCollection( sites map[string]string, su support.StatusUpdater, ) (data.BackupCollection, error) { - // TODO(meain): Switch to using BuildMetadata - // https://github.com/alcionai/corso/pull/4184#discussion_r1316139701 - p, err := path.Builder{}.ToServiceCategoryMetadataPath( + p, err := path.BuildMetadata( tenantID, groupID, path.GroupsService,