Refactor base finder tests to be more compact and easier to make (#4586)

Browse Source

These tests were originally written before we checked backup
models when searching for bases. This refactor updates the
tests with helper functions that create self-consistent
backup and manifest models. Overall this pattern makes it
easier to declare the data the test uses, easier to read
test data, and makes the tests more compact

Reviewing this PR by commit may be easier

---

#### Does this PR need a docs update or release note?

- [ ] ✅ Yes, it's included
- [ ] 🕐 Yes, but in a later PR
- [x] ⛔ No

#### Type of change

- [ ] 🌻 Feature
- [ ] 🐛 Bugfix
- [ ] 🗺️ Documentation
- [x] 🤖 Supportability/Tests
- [ ] 💻 CI/Deployment
- [ ] 🧹 Tech Debt/Cleanup

#### Test Plan

- [x] 💪 Manual
- [ ] ⚡ Unit test
- [ ] 💚 E2E

...

This commit is contained in:

ashmrtn 2023-10-31 15:32:16 -07:00 committed by GitHub

parent c6464555dd

commit 3e13471ac6

No known key found for this signature in database

GPG Key ID: 4AEE18F83AFDEB23

1 changed files with 343 additions and 653 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Show Stats Download Patch File Download Diff File Expand all files Collapse all files

996

src/internal/kopia/base_finder_test.go

File diff suppressed because it is too large Load Diff