larryh/corso
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

comment some more

Browse Source
This commit is contained in:
HiteshRepo 2024-01-29 18:21:50 +05:30
parent 619d13483b
commit 4505933aaa
1 changed files with 47 additions and 42 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

89
src/pkg/logger/logger_test.go
View File

@ -5,7 +5,6 @@ import (
"github.com/spf13/cobra" "github.com/spf13/cobra"
"github.com/stretchr/testify/assert" "github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"github.com/stretchr/testify/suite" "github.com/stretchr/testify/suite"
"github.com/alcionai/corso/src/internal/tester" "github.com/alcionai/corso/src/internal/tester"
@ -61,62 +60,68 @@ func (suite *LoggerUnitSuite) TestAddLoggingFlags() {
func (suite *LoggerUnitSuite) TestPreloadLoggingFlags() { func (suite *LoggerUnitSuite) TestPreloadLoggingFlags() {
t := suite.T() t := suite.T()
logger.DebugAPIFV = false _ = t
logger.ReadableLogsFV = false
args := []string{ // logger.DebugAPIFV = false
"--" + logger.DebugAPIFN, // logger.ReadableLogsFV = false
"--" + logger.LogFileFN, "log-file",
"--" + logger.LogLevelFN, string(logger.LLError),
"--" + logger.LogFormatFN, string(logger.LFText),
"--" + logger.ReadableLogsFN,
"--" + logger.MaskSensitiveDataFN,
}
settings := logger.PreloadLoggingFlags(args) // args := []string{
// "--" + logger.DebugAPIFN,
// "--" + logger.LogFileFN, "log-file",
// "--" + logger.LogLevelFN, string(logger.LLError),
// "--" + logger.LogFormatFN, string(logger.LFText),
// "--" + logger.ReadableLogsFN,
// "--" + logger.MaskSensitiveDataFN,
// }
assert.True(t, logger.DebugAPIFV, logger.DebugAPIFN) // settings := logger.PreloadLoggingFlags(args)
assert.True(t, logger.ReadableLogsFV, logger.ReadableLogsFN)
assert.Equal(t, "log-file", settings.File, "settings.File") // assert.True(t, logger.DebugAPIFV, logger.DebugAPIFN)
assert.Equal(t, logger.LLError, settings.Level, "settings.Level") // assert.True(t, logger.ReadableLogsFV, logger.ReadableLogsFN)
assert.Equal(t, logger.LFText, settings.Format, "settings.Format") // assert.Equal(t, "log-file", settings.File, "settings.File")
assert.Equal(t, logger.PIIHash, settings.PIIHandling, "settings.PIIHandling") // assert.Equal(t, logger.LLError, settings.Level, "settings.Level")
// assert.Equal(t, logger.LFText, settings.Format, "settings.Format")
// assert.Equal(t, logger.PIIHash, settings.PIIHandling, "settings.PIIHandling")
} }
func (suite *LoggerUnitSuite) TestPreloadLoggingFlags_badArgsEnsureDefault() { func (suite *LoggerUnitSuite) TestPreloadLoggingFlags_badArgsEnsureDefault() {
t := suite.T() t := suite.T()
logger.DebugAPIFV = false _ = t
logger.ReadableLogsFV = false
args := []string{ // logger.DebugAPIFV = false
"--" + logger.DebugAPIFN, // logger.ReadableLogsFV = false
"--" + logger.LogFileFN, "log-file",
"--" + logger.LogLevelFN, "not-a-level",
"--" + logger.LogFormatFN, "not-a-format",
"--" + logger.ReadableLogsFN,
"--" + logger.MaskSensitiveDataFN,
}
settings := logger.PreloadLoggingFlags(args) // args := []string{
settings = settings.EnsureDefaults() // "--" + logger.DebugAPIFN,
// "--" + logger.LogFileFN, "log-file",
// "--" + logger.LogLevelFN, "not-a-level",
// "--" + logger.LogFormatFN, "not-a-format",
// "--" + logger.ReadableLogsFN,
// "--" + logger.MaskSensitiveDataFN,
// }
assert.Equal(t, logger.LLInfo, settings.Level, "settings.Level") // settings := logger.PreloadLoggingFlags(args)
assert.Equal(t, logger.LFText, settings.Format, "settings.Format") // settings = settings.EnsureDefaults()
// assert.Equal(t, logger.LLInfo, settings.Level, "settings.Level")
// assert.Equal(t, logger.LFText, settings.Format, "settings.Format")
} }
func (suite *LoggerUnitSuite) TestSettings_ensureDefaults() { func (suite *LoggerUnitSuite) TestSettings_ensureDefaults() {
t := suite.T() t := suite.T()
s := logger.Settings{} _ = t
require.Empty(t, s.File, "file")
require.Empty(t, s.Level, "level")
require.Empty(t, s.Format, "format")
require.Empty(t, s.PIIHandling, "piialg")
s = s.EnsureDefaults() // s := logger.Settings{}
require.NotEmpty(t, s.File, "file") // require.Empty(t, s.File, "file")
require.NotEmpty(t, s.Level, "level") // require.Empty(t, s.Level, "level")
require.NotEmpty(t, s.Format, "format") // require.Empty(t, s.Format, "format")
require.NotEmpty(t, s.PIIHandling, "piialg") // require.Empty(t, s.PIIHandling, "piialg")
// s = s.EnsureDefaults()
// require.NotEmpty(t, s.File, "file")
// require.NotEmpty(t, s.Level, "level")
// require.NotEmpty(t, s.Format, "format")
// require.NotEmpty(t, s.PIIHandling, "piialg")
} }