Drop TODOs that are not relevant anymore (#4280)

<!-- PR description-->

---

#### Does this PR need a docs update or release note?

- [ ]  Yes, it's included
- [ ] 🕐 Yes, but in a later PR
- [x]  No

#### Type of change

<!--- Please check the type of change your PR introduces: --->
- [ ] 🌻 Feature
- [ ] 🐛 Bugfix
- [ ] 🗺️ Documentation
- [ ] 🤖 Supportability/Tests
- [ ] 💻 CI/Deployment
- [x] 🧹 Tech Debt/Cleanup

#### Issue(s)

<!-- Can reference multiple issues. Use one of the following "magic words" - "closes, fixes" to auto-close the Github issue. -->
* #<issue>

#### Test Plan

<!-- How will this be tested prior to merging.-->
- [ ] 💪 Manual
- [ ]  Unit test
- [ ] 💚 E2E
This commit is contained in:
Abin Simon 2023-09-18 17:37:09 +05:30 committed by GitHub
parent cbff2173ec
commit 471a0fa35a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 2 additions and 7 deletions

View File

@ -138,8 +138,6 @@ func ValidateGroupsRestoreFlags(backupID string, opts GroupsOpts) error {
return clues.New("invalid time format for " + flags.MessageLastReplyBeforeFN)
}
// TODO(meain): selectors (refer sharepoint)
return validateRestoreConfigFlags(flags.CollisionsFV, opts.RestoreCfg)
}

View File

@ -15,7 +15,6 @@ import (
const (
// ZipCopyBufferSize is the size of the copy buffer for zip
// write operations
// TODO(meain): tweak this value
ZipCopyBufferSize = 5 * 1024 * 1024
)

View File

@ -198,7 +198,6 @@ func (oc *Collection) Remove(itemID string) bool {
}
// IsEmpty check if a collection does not contain any items
// TODO(meain): Should we just have function that returns driveItems?
func (oc *Collection) IsEmpty() bool {
return len(oc.driveItems) == 0
}

View File

@ -2492,7 +2492,7 @@ func delItem(
}
func getDeltaError() error {
syncStateNotFound := "SyncStateNotFound" // TODO(meain): export graph.errCodeSyncStateNotFound
syncStateNotFound := "SyncStateNotFound"
me := odataerrors.NewMainError()
me.SetCode(&syncStateNotFound)

View File

@ -33,7 +33,7 @@ func (ctrl *Controller) ProduceExportCollections(
defer end()
ctx = graph.BindRateLimiterConfig(ctx, graph.LimiterCfg{Service: sels.PathService()})
ctx = clues.Add(ctx, "export_config", exportCfg) // TODO(meain): needs PII control
ctx = clues.Add(ctx, "export_config", exportCfg)
var (
expCollections []export.Collectioner

View File

@ -34,7 +34,6 @@ import (
const (
// CopyBufferSize is the size of the copy buffer for disk
// write operations
// TODO(meain): tweak this value
CopyBufferSize = 5 * 1024 * 1024
)