Drop TODOs that are not relevant anymore (#4280)
<!-- PR description--> --- #### Does this PR need a docs update or release note? - [ ] ✅ Yes, it's included - [ ] 🕐 Yes, but in a later PR - [x] ⛔ No #### Type of change <!--- Please check the type of change your PR introduces: ---> - [ ] 🌻 Feature - [ ] 🐛 Bugfix - [ ] 🗺️ Documentation - [ ] 🤖 Supportability/Tests - [ ] 💻 CI/Deployment - [x] 🧹 Tech Debt/Cleanup #### Issue(s) <!-- Can reference multiple issues. Use one of the following "magic words" - "closes, fixes" to auto-close the Github issue. --> * #<issue> #### Test Plan <!-- How will this be tested prior to merging.--> - [ ] 💪 Manual - [ ] ⚡ Unit test - [ ] 💚 E2E
This commit is contained in:
parent
cbff2173ec
commit
471a0fa35a
@ -138,8 +138,6 @@ func ValidateGroupsRestoreFlags(backupID string, opts GroupsOpts) error {
|
|||||||
return clues.New("invalid time format for " + flags.MessageLastReplyBeforeFN)
|
return clues.New("invalid time format for " + flags.MessageLastReplyBeforeFN)
|
||||||
}
|
}
|
||||||
|
|
||||||
// TODO(meain): selectors (refer sharepoint)
|
|
||||||
|
|
||||||
return validateRestoreConfigFlags(flags.CollisionsFV, opts.RestoreCfg)
|
return validateRestoreConfigFlags(flags.CollisionsFV, opts.RestoreCfg)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@ -15,7 +15,6 @@ import (
|
|||||||
const (
|
const (
|
||||||
// ZipCopyBufferSize is the size of the copy buffer for zip
|
// ZipCopyBufferSize is the size of the copy buffer for zip
|
||||||
// write operations
|
// write operations
|
||||||
// TODO(meain): tweak this value
|
|
||||||
ZipCopyBufferSize = 5 * 1024 * 1024
|
ZipCopyBufferSize = 5 * 1024 * 1024
|
||||||
)
|
)
|
||||||
|
|
||||||
|
|||||||
@ -198,7 +198,6 @@ func (oc *Collection) Remove(itemID string) bool {
|
|||||||
}
|
}
|
||||||
|
|
||||||
// IsEmpty check if a collection does not contain any items
|
// IsEmpty check if a collection does not contain any items
|
||||||
// TODO(meain): Should we just have function that returns driveItems?
|
|
||||||
func (oc *Collection) IsEmpty() bool {
|
func (oc *Collection) IsEmpty() bool {
|
||||||
return len(oc.driveItems) == 0
|
return len(oc.driveItems) == 0
|
||||||
}
|
}
|
||||||
|
|||||||
@ -2492,7 +2492,7 @@ func delItem(
|
|||||||
}
|
}
|
||||||
|
|
||||||
func getDeltaError() error {
|
func getDeltaError() error {
|
||||||
syncStateNotFound := "SyncStateNotFound" // TODO(meain): export graph.errCodeSyncStateNotFound
|
syncStateNotFound := "SyncStateNotFound"
|
||||||
me := odataerrors.NewMainError()
|
me := odataerrors.NewMainError()
|
||||||
me.SetCode(&syncStateNotFound)
|
me.SetCode(&syncStateNotFound)
|
||||||
|
|
||||||
|
|||||||
@ -33,7 +33,7 @@ func (ctrl *Controller) ProduceExportCollections(
|
|||||||
defer end()
|
defer end()
|
||||||
|
|
||||||
ctx = graph.BindRateLimiterConfig(ctx, graph.LimiterCfg{Service: sels.PathService()})
|
ctx = graph.BindRateLimiterConfig(ctx, graph.LimiterCfg{Service: sels.PathService()})
|
||||||
ctx = clues.Add(ctx, "export_config", exportCfg) // TODO(meain): needs PII control
|
ctx = clues.Add(ctx, "export_config", exportCfg)
|
||||||
|
|
||||||
var (
|
var (
|
||||||
expCollections []export.Collectioner
|
expCollections []export.Collectioner
|
||||||
|
|||||||
@ -34,7 +34,6 @@ import (
|
|||||||
const (
|
const (
|
||||||
// CopyBufferSize is the size of the copy buffer for disk
|
// CopyBufferSize is the size of the copy buffer for disk
|
||||||
// write operations
|
// write operations
|
||||||
// TODO(meain): tweak this value
|
|
||||||
CopyBufferSize = 5 * 1024 * 1024
|
CopyBufferSize = 5 * 1024 * 1024
|
||||||
)
|
)
|
||||||
|
|
||||||
|
|||||||
Loading…
x
Reference in New Issue
Block a user