From 4ace4bee761ccfcee1f2feb759d40dece1b52811 Mon Sep 17 00:00:00 2001
From: Abhishek Pandey <abhishek@alcion.ai>
Date: Tue, 22 Aug 2023 18:25:08 +0530
Subject: [PATCH] Remove duplicate mocks from kopia wrapper tests (#4083)

<!-- PR description-->

No logic changes. Only removing duplicate test code.


---

#### Does this PR need a docs update or release note?

- [ ] :white_check_mark: Yes, it's included
- [ ] :clock1: Yes, but in a later PR
- [x] :no_entry: No

#### Type of change

<!--- Please check the type of change your PR introduces: --->
- [ ] :sunflower: Feature
- [ ] :bug: Bugfix
- [ ] :world_map: Documentation
- [ ] :robot: Supportability/Tests
- [ ] :computer: CI/Deployment
- [x] :broom: Tech Debt/Cleanup

#### Issue(s)

<!-- Can reference multiple issues. Use one of the following "magic words" - "closes, fixes" to auto-close the Github issue. -->
* #<issue>

#### Test Plan

<!-- How will this be tested prior to merging.-->
- [ ] :muscle: Manual
- [x] :zap: Unit test
- [ ] :green_heart: E2E
---
 src/internal/kopia/wrapper_test.go | 83 ++++++++----------------------
 1 file changed, 21 insertions(+), 62 deletions(-)

diff --git a/src/internal/kopia/wrapper_test.go b/src/internal/kopia/wrapper_test.go
index a21b954a9..8c511a6f0 100644
--- a/src/internal/kopia/wrapper_test.go
+++ b/src/internal/kopia/wrapper_test.go
@@ -25,6 +25,7 @@ import (
 	"github.com/alcionai/corso/src/internal/data"
 	dataMock "github.com/alcionai/corso/src/internal/data/mock"
 	"github.com/alcionai/corso/src/internal/m365/collection/drive/metadata"
+	m365Mock "github.com/alcionai/corso/src/internal/m365/mock"
 	exchMock "github.com/alcionai/corso/src/internal/m365/service/exchange/mock"
 	"github.com/alcionai/corso/src/internal/tester"
 	"github.com/alcionai/corso/src/pkg/backup/details"
@@ -1128,10 +1129,10 @@ func (suite *KopiaIntegrationSuite) TestBackupCollections_NoDetailsForMeta() {
 					streams = append(streams, ms)
 				}
 
-				mc := &mockBackupCollection{
-					path:    storePath,
-					loc:     locPath,
-					streams: streams,
+				mc := &m365Mock.BackupCollection{
+					Path:    storePath,
+					Loc:     locPath,
+					Streams: streams,
 				}
 
 				return []data.BackupCollection{mc}
@@ -1155,11 +1156,11 @@ func (suite *KopiaIntegrationSuite) TestBackupCollections_NoDetailsForMeta() {
 					ItemInfo: details.ItemInfo{OneDrive: &info},
 				}
 
-				mc := &mockBackupCollection{
-					path:    storePath,
-					loc:     locPath,
-					streams: []data.Item{ms},
-					state:   data.NotMovedState,
+				mc := &m365Mock.BackupCollection{
+					Path:    storePath,
+					Loc:     locPath,
+					Streams: []data.Item{ms},
+					CState:  data.NotMovedState,
 				}
 
 				return []data.BackupCollection{mc}
@@ -1293,48 +1294,6 @@ func (suite *KopiaIntegrationSuite) TestRestoreAfterCompressionChange() {
 	testForFiles(t, ctx, expected, result)
 }
 
-// TODO(pandeyabs): Switch to m365/mock/BackupCollection.
-type mockBackupCollection struct {
-	path    path.Path
-	loc     *path.Builder
-	streams []data.Item
-	state   data.CollectionState
-}
-
-func (c *mockBackupCollection) Items(context.Context, *fault.Bus) <-chan data.Item {
-	res := make(chan data.Item)
-
-	go func() {
-		defer close(res)
-
-		for _, s := range c.streams {
-			res <- s
-		}
-	}()
-
-	return res
-}
-
-func (c mockBackupCollection) FullPath() path.Path {
-	return c.path
-}
-
-func (c mockBackupCollection) PreviousPath() path.Path {
-	return c.path
-}
-
-func (c mockBackupCollection) LocationPath() *path.Builder {
-	return c.loc
-}
-
-func (c mockBackupCollection) State() data.CollectionState {
-	return c.state
-}
-
-func (c mockBackupCollection) DoNotMergeItems() bool {
-	return false
-}
-
 func (suite *KopiaIntegrationSuite) TestBackupCollections_ReaderError() {
 	t := suite.T()
 
@@ -1343,10 +1302,10 @@ func (suite *KopiaIntegrationSuite) TestBackupCollections_ReaderError() {
 	r := NewReason(testTenant, testUser, path.ExchangeService, path.EmailCategory)
 
 	collections := []data.BackupCollection{
-		&mockBackupCollection{
-			path: suite.storePath1,
-			loc:  loc1,
-			streams: []data.Item{
+		&m365Mock.BackupCollection{
+			Path: suite.storePath1,
+			Loc:  loc1,
+			Streams: []data.Item{
 				&dataMock.Item{
 					ItemID:   testFileName,
 					Reader:   io.NopCloser(bytes.NewReader(testFileData)),
@@ -1359,10 +1318,10 @@ func (suite *KopiaIntegrationSuite) TestBackupCollections_ReaderError() {
 				},
 			},
 		},
-		&mockBackupCollection{
-			path: suite.storePath2,
-			loc:  loc2,
-			streams: []data.Item{
+		&m365Mock.BackupCollection{
+			Path: suite.storePath2,
+			Loc:  loc2,
+			Streams: []data.Item{
 				&dataMock.Item{
 					ItemID:   testFileName3,
 					Reader:   io.NopCloser(bytes.NewReader(testFileData3)),
@@ -1603,11 +1562,11 @@ func (suite *KopiaSimpleRepoIntegrationSuite) SetupTest() {
 
 	for _, parent := range []path.Path{suite.testPath1, suite.testPath2} {
 		loc := path.Builder{}.Append(parent.Folders()...)
-		collection := &mockBackupCollection{path: parent, loc: loc}
+		collection := &m365Mock.BackupCollection{Path: parent, Loc: loc}
 
 		for _, item := range suite.files[parent.String()] {
-			collection.streams = append(
-				collection.streams,
+			collection.Streams = append(
+				collection.Streams,
 				&dataMock.Item{
 					ItemID:   item.itemPath.Item(),
 					Reader:   io.NopCloser(bytes.NewReader(item.data)),