diff --git a/src/internal/connector/discovery/discovery.go b/src/internal/connector/discovery/discovery.go index f4ac9efaa..82a9b916b 100644 --- a/src/internal/connector/discovery/discovery.go +++ b/src/internal/connector/discovery/discovery.go @@ -6,10 +6,10 @@ import ( "github.com/alcionai/clues" "github.com/microsoftgraph/msgraph-sdk-go/models" - "github.com/alcionai/corso/src/internal/connector/discovery/api" "github.com/alcionai/corso/src/internal/connector/graph" "github.com/alcionai/corso/src/pkg/account" "github.com/alcionai/corso/src/pkg/fault" + "github.com/alcionai/corso/src/pkg/services/m365/api" ) // --------------------------------------------------------------------------- diff --git a/src/internal/connector/discovery/discovery_test.go b/src/internal/connector/discovery/discovery_test.go index 4da2c3867..dd9971b08 100644 --- a/src/internal/connector/discovery/discovery_test.go +++ b/src/internal/connector/discovery/discovery_test.go @@ -10,12 +10,12 @@ import ( "github.com/stretchr/testify/suite" "github.com/alcionai/corso/src/internal/connector/discovery" - "github.com/alcionai/corso/src/internal/connector/discovery/api" "github.com/alcionai/corso/src/internal/tester" "github.com/alcionai/corso/src/pkg/account" "github.com/alcionai/corso/src/pkg/credentials" "github.com/alcionai/corso/src/pkg/fault" "github.com/alcionai/corso/src/pkg/path" + "github.com/alcionai/corso/src/pkg/services/m365/api" ) type DiscoveryIntegrationSuite struct { diff --git a/src/internal/connector/graph_connector.go b/src/internal/connector/graph_connector.go index beed67bfa..94e9e1634 100644 --- a/src/internal/connector/graph_connector.go +++ b/src/internal/connector/graph_connector.go @@ -11,13 +11,13 @@ import ( "github.com/alcionai/clues" "github.com/alcionai/corso/src/internal/common" - "github.com/alcionai/corso/src/internal/connector/discovery/api" "github.com/alcionai/corso/src/internal/connector/graph" "github.com/alcionai/corso/src/internal/connector/support" "github.com/alcionai/corso/src/internal/data" "github.com/alcionai/corso/src/internal/operations/inject" "github.com/alcionai/corso/src/pkg/account" "github.com/alcionai/corso/src/pkg/fault" + "github.com/alcionai/corso/src/pkg/services/m365/api" ) // --------------------------------------------------------------------------- diff --git a/src/internal/connector/sharepoint/api/helper_test.go b/src/internal/connector/sharepoint/api/helper_test.go index e1982a178..d7c21c2a9 100644 --- a/src/internal/connector/sharepoint/api/helper_test.go +++ b/src/internal/connector/sharepoint/api/helper_test.go @@ -6,17 +6,17 @@ import ( "github.com/alcionai/clues" "github.com/stretchr/testify/require" - discover "github.com/alcionai/corso/src/internal/connector/discovery/api" "github.com/alcionai/corso/src/internal/connector/graph" "github.com/alcionai/corso/src/pkg/account" + "github.com/alcionai/corso/src/pkg/services/m365/api" ) -func createTestBetaService(t *testing.T, credentials account.M365Config) *discover.BetaService { +func createTestBetaService(t *testing.T, credentials account.M365Config) *api.BetaService { adapter, err := graph.CreateAdapter( credentials.AzureTenantID, credentials.AzureClientID, credentials.AzureClientSecret) require.NoError(t, err, clues.ToCore(err)) - return discover.NewBetaService(adapter) + return api.NewBetaService(adapter) } diff --git a/src/internal/connector/sharepoint/api/pages.go b/src/internal/connector/sharepoint/api/pages.go index 6b5800d20..32bcafef1 100644 --- a/src/internal/connector/sharepoint/api/pages.go +++ b/src/internal/connector/sharepoint/api/pages.go @@ -11,7 +11,6 @@ import ( "github.com/microsoftgraph/msgraph-sdk-go/sites" "github.com/alcionai/corso/src/internal/common/ptr" - dapi "github.com/alcionai/corso/src/internal/connector/discovery/api" "github.com/alcionai/corso/src/internal/connector/graph" betamodels "github.com/alcionai/corso/src/internal/connector/graph/betasdk/models" betasites "github.com/alcionai/corso/src/internal/connector/graph/betasdk/sites" @@ -20,13 +19,14 @@ import ( "github.com/alcionai/corso/src/internal/diagnostics" "github.com/alcionai/corso/src/pkg/backup/details" "github.com/alcionai/corso/src/pkg/fault" + "github.com/alcionai/corso/src/pkg/services/m365/api" ) // GetSitePages retrieves a collection of Pages related to the give Site. // Returns error if error experienced during the call func GetSitePages( ctx context.Context, - serv *dapi.BetaService, + serv *api.BetaService, siteID string, pages []string, errs *fault.Bus, @@ -100,7 +100,7 @@ func GetSite(ctx context.Context, gs graph.Servicer, siteID string) (models.Site } // fetchPages utility function to return the tuple of item -func FetchPages(ctx context.Context, bs *dapi.BetaService, siteID string) ([]NameID, error) { +func FetchPages(ctx context.Context, bs *api.BetaService, siteID string) ([]NameID, error) { var ( builder = bs.Client().SitesById(siteID).Pages() opts = fetchPageOptions() @@ -159,7 +159,7 @@ func fetchPageOptions() *betasites.ItemPagesRequestBuilderGetRequestConfiguratio // https://github.com/alcionai/corso/issues/2707 func DeleteSitePage( ctx context.Context, - serv *dapi.BetaService, + serv *api.BetaService, siteID, pageID string, ) error { err := serv.Client().SitesById(siteID).PagesById(pageID).Delete(ctx, nil) @@ -184,7 +184,7 @@ func retrieveSitePageOptions() *betasites.ItemPagesSitePageItemRequestBuilderGet func RestoreSitePage( ctx context.Context, - service *dapi.BetaService, + service *api.BetaService, itemData data.Stream, siteID, destName string, ) (details.ItemInfo, error) { diff --git a/src/internal/connector/sharepoint/api/pages_test.go b/src/internal/connector/sharepoint/api/pages_test.go index 49775b87e..3e52402be 100644 --- a/src/internal/connector/sharepoint/api/pages_test.go +++ b/src/internal/connector/sharepoint/api/pages_test.go @@ -11,20 +11,20 @@ import ( "github.com/stretchr/testify/suite" "github.com/alcionai/corso/src/internal/common" - discover "github.com/alcionai/corso/src/internal/connector/discovery/api" "github.com/alcionai/corso/src/internal/connector/sharepoint" "github.com/alcionai/corso/src/internal/connector/sharepoint/api" spMock "github.com/alcionai/corso/src/internal/connector/sharepoint/mock" "github.com/alcionai/corso/src/internal/tester" "github.com/alcionai/corso/src/pkg/account" "github.com/alcionai/corso/src/pkg/fault" + m365api "github.com/alcionai/corso/src/pkg/services/m365/api" ) type SharePointPageSuite struct { tester.Suite siteID string creds account.M365Config - service *discover.BetaService + service *m365api.BetaService } func (suite *SharePointPageSuite) SetupSuite() { diff --git a/src/internal/connector/sharepoint/collection.go b/src/internal/connector/sharepoint/collection.go index 8ff364510..2a835b4bf 100644 --- a/src/internal/connector/sharepoint/collection.go +++ b/src/internal/connector/sharepoint/collection.go @@ -11,7 +11,6 @@ import ( kjson "github.com/microsoft/kiota-serialization-json-go" "github.com/alcionai/corso/src/internal/common/ptr" - dapi "github.com/alcionai/corso/src/internal/connector/discovery/api" "github.com/alcionai/corso/src/internal/connector/graph" "github.com/alcionai/corso/src/internal/connector/sharepoint/api" "github.com/alcionai/corso/src/internal/connector/support" @@ -22,6 +21,7 @@ import ( "github.com/alcionai/corso/src/pkg/fault" "github.com/alcionai/corso/src/pkg/logger" "github.com/alcionai/corso/src/pkg/path" + m365api "github.com/alcionai/corso/src/pkg/services/m365/api" ) type DataCategory int @@ -56,7 +56,7 @@ type Collection struct { category DataCategory service graph.Servicer ctrl control.Options - betaService *dapi.BetaService + betaService *m365api.BetaService statusUpdater support.StatusUpdater } diff --git a/src/internal/connector/sharepoint/data_collections.go b/src/internal/connector/sharepoint/data_collections.go index 4c3895bc3..815f3b1bb 100644 --- a/src/internal/connector/sharepoint/data_collections.go +++ b/src/internal/connector/sharepoint/data_collections.go @@ -6,7 +6,6 @@ import ( "github.com/alcionai/clues" - dapi "github.com/alcionai/corso/src/internal/connector/discovery/api" "github.com/alcionai/corso/src/internal/connector/graph" "github.com/alcionai/corso/src/internal/connector/onedrive" "github.com/alcionai/corso/src/internal/connector/sharepoint/api" @@ -19,6 +18,7 @@ import ( "github.com/alcionai/corso/src/pkg/logger" "github.com/alcionai/corso/src/pkg/path" "github.com/alcionai/corso/src/pkg/selectors" + m365api "github.com/alcionai/corso/src/pkg/services/m365/api" ) type statusUpdater interface { @@ -243,7 +243,7 @@ func collectPages( return nil, clues.Wrap(err, "creating azure client adapter") } - betaService := dapi.NewBetaService(adpt) + betaService := m365api.NewBetaService(adpt) tuples, err := api.FetchPages(ctx, betaService, siteID) if err != nil { diff --git a/src/internal/connector/sharepoint/restore.go b/src/internal/connector/sharepoint/restore.go index 816494130..351230d6a 100644 --- a/src/internal/connector/sharepoint/restore.go +++ b/src/internal/connector/sharepoint/restore.go @@ -10,7 +10,6 @@ import ( "github.com/microsoftgraph/msgraph-sdk-go/models" "github.com/alcionai/corso/src/internal/common/ptr" - dapi "github.com/alcionai/corso/src/internal/connector/discovery/api" "github.com/alcionai/corso/src/internal/connector/graph" "github.com/alcionai/corso/src/internal/connector/onedrive" "github.com/alcionai/corso/src/internal/connector/sharepoint/api" @@ -23,6 +22,7 @@ import ( "github.com/alcionai/corso/src/pkg/fault" "github.com/alcionai/corso/src/pkg/logger" "github.com/alcionai/corso/src/pkg/path" + m365api "github.com/alcionai/corso/src/pkg/services/m365/api" ) //---------------------------------------------------------------------------- @@ -315,7 +315,7 @@ func RestorePageCollection( var ( el = errs.Local() - service = dapi.NewBetaService(adpt) + service = m365api.NewBetaService(adpt) items = dc.Items(ctx, errs) ) diff --git a/src/internal/connector/discovery/api/api.go b/src/pkg/services/m365/api/api.go similarity index 73% rename from src/internal/connector/discovery/api/api.go rename to src/pkg/services/m365/api/api.go index efcf48159..37b9b48a7 100644 --- a/src/internal/connector/discovery/api/api.go +++ b/src/pkg/services/m365/api/api.go @@ -11,12 +11,11 @@ import ( // interfaces // --------------------------------------------------------------------------- -// Client is used to fulfill the interface for discovery -// queries that are traditionally backed by GraphAPI. A -// struct is used in this case, instead of deferring to -// pure function wrappers, so that the boundary separates the -// granular implementation of the graphAPI and kiota away -// from the exchange package's broader intents. +// Client is used to fulfill queries that are traditionally +// backed by GraphAPI. A struct is used in this case, instead +// of deferring to pure function wrappers, so that the boundary +// separates the granular implementation of the graphAPI and +// kiota away from the other packages. type Client struct { Credentials account.M365Config @@ -25,7 +24,7 @@ type Client struct { stable graph.Servicer } -// NewClient produces a new exchange api client. Must be used in +// NewClient produces a new api client. Must be used in // place of creating an ad-hoc client struct. func NewClient(creds account.M365Config) (Client, error) { s, err := newService(creds) @@ -39,7 +38,7 @@ func NewClient(creds account.M365Config) (Client, error) { // service generates a new service. Used for paged and other long-running // requests instead of the client's stable service, so that in-flight state // within the adapter doesn't get clobbered -func (c Client) service() (*graph.Service, error) { +func (c Client) Service() (*graph.Service, error) { return newService(c.Credentials) } diff --git a/src/internal/connector/discovery/api/beta_service.go b/src/pkg/services/m365/api/beta_service.go similarity index 100% rename from src/internal/connector/discovery/api/beta_service.go rename to src/pkg/services/m365/api/beta_service.go diff --git a/src/internal/connector/discovery/api/beta_service_test.go b/src/pkg/services/m365/api/beta_service_test.go similarity index 100% rename from src/internal/connector/discovery/api/beta_service_test.go rename to src/pkg/services/m365/api/beta_service_test.go diff --git a/src/internal/connector/discovery/api/sites.go b/src/pkg/services/m365/api/sites.go similarity index 99% rename from src/internal/connector/discovery/api/sites.go rename to src/pkg/services/m365/api/sites.go index f45b2af39..837d836d4 100644 --- a/src/internal/connector/discovery/api/sites.go +++ b/src/pkg/services/m365/api/sites.go @@ -37,7 +37,7 @@ type Sites struct { // GetAll retrieves all sites. func (c Sites) GetAll(ctx context.Context, errs *fault.Bus) ([]models.Siteable, error) { - service, err := c.service() + service, err := c.Service() if err != nil { return nil, err } diff --git a/src/internal/connector/discovery/api/sites_test.go b/src/pkg/services/m365/api/sites_test.go similarity index 100% rename from src/internal/connector/discovery/api/sites_test.go rename to src/pkg/services/m365/api/sites_test.go diff --git a/src/internal/connector/discovery/api/users.go b/src/pkg/services/m365/api/users.go similarity index 99% rename from src/internal/connector/discovery/api/users.go rename to src/pkg/services/m365/api/users.go index b47fc1184..9fa76421f 100644 --- a/src/internal/connector/discovery/api/users.go +++ b/src/pkg/services/m365/api/users.go @@ -100,7 +100,7 @@ func userOptions(fs *string) *users.UsersRequestBuilderGetRequestConfiguration { // GetAll retrieves all users. func (c Users) GetAll(ctx context.Context, errs *fault.Bus) ([]models.Userable, error) { - service, err := c.service() + service, err := c.Service() if err != nil { return nil, err } diff --git a/src/internal/connector/discovery/api/users_test.go b/src/pkg/services/m365/api/users_test.go similarity index 100% rename from src/internal/connector/discovery/api/users_test.go rename to src/pkg/services/m365/api/users_test.go diff --git a/src/pkg/services/m365/m365.go b/src/pkg/services/m365/m365.go index fc1a66034..97f724f76 100644 --- a/src/pkg/services/m365/m365.go +++ b/src/pkg/services/m365/m365.go @@ -10,10 +10,10 @@ import ( "github.com/alcionai/corso/src/internal/common" "github.com/alcionai/corso/src/internal/common/ptr" "github.com/alcionai/corso/src/internal/connector/discovery" - "github.com/alcionai/corso/src/internal/connector/discovery/api" "github.com/alcionai/corso/src/pkg/account" "github.com/alcionai/corso/src/pkg/fault" "github.com/alcionai/corso/src/pkg/path" + "github.com/alcionai/corso/src/pkg/services/m365/api" ) // ServiceAccess is true if a resource owner is capable of