larryh/corso
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add partial backup flag

Browse Source
This commit is contained in:
Abhishek Pandey 2023-07-21 00:29:16 -07:00
parent 748ff803d1
commit 52f462abf9
1 changed files with 16 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
src/internal/operations/backup.go
View File

@ -227,6 +227,9 @@ func (op *BackupOperation) Run(ctx context.Context) (err error) {
op.Errors.Fail(clues.Wrap(err, "running backup")) op.Errors.Fail(clues.Wrap(err, "running backup"))
} }
isPartialBackup := err != nil &&
(deets == nil || deets.Empty())
finalizeErrorHandling(ctx, op.Options, op.Errors, "running backup") finalizeErrorHandling(ctx, op.Options, op.Errors, "running backup")
LogFaultErrors(ctx, op.Errors.Errors(), "running backup") LogFaultErrors(ctx, op.Errors.Errors(), "running backup")
@ -235,24 +238,26 @@ func (op *BackupOperation) Run(ctx context.Context) (err error) {
// ----- // -----
err = op.persistResults(startTime, &opStats) err = op.persistResults(startTime, &opStats)
if err != nil && (deets == nil || deets.Empty()) { if err != nil && !isPartialBackup {
op.Errors.Fail(clues.Wrap(err, "persisting backup results")) op.Errors.Fail(clues.Wrap(err, "persisting backup results"))
return op.Errors.Failure() return op.Errors.Failure()
} }
// force exit without backup in certain cases. // force exit without backup in certain cases.
// see: https://github.com/alcionai/corso/pull/2510#discussion_r1113532530 // see: https://github.com/alcionai/corso/pull/2510#discussion_r1113532530
// for _, e := range op.Errors.Recovered() { for _, e := range op.Errors.Recovered() {
// if clues.HasLabel(e, fault.LabelForceNoBackupCreation) { if clues.HasLabel(e, fault.LabelForceNoBackupCreation) {
// logger.Ctx(ctx). logger.Ctx(ctx).
// With("error", e). With("error", e).
// With(clues.InErr(err).Slice()...). With(clues.InErr(err).Slice()...).
// Infow("completed backup; conditional error forcing exit without model persistence", Infow("completed backup; conditional error forcing exit without model persistence",
// "results", op.Results) "results", op.Results)
// return op.Errors.Fail(clues.Wrap(e, "forced backup")).Failure() if !isPartialBackup {
// } return op.Errors.Fail(clues.Wrap(e, "forced backup")).Failure()
// } }
}
}
err = op.createBackupModels( err = op.createBackupModels(
ctx, ctx,