larryh/corso
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Disable kopia incrementals for OneDrive (#2132)

Browse Source 
## Description

Kopia-assisted incremental backups do not appear to have the correct file size set on restore

## Does this PR need a docs update or release note?

- [ ] ✅ Yes, it's included
- [ ] 🕐 Yes, but in a later PR
- [x] ⛔ No 

## Type of change

<!--- Please check the type of change your PR introduces: --->
- [ ] 🌻 Feature
- [x] 🐛 Bugfix
- [ ] 🗺️ Documentation
- [ ] 🤖 Test
- [ ] 💻 CI/Deployment
- [ ] 🧹 Tech Debt/Cleanup

## Issue(s)

<!-- Can reference multiple issues. Use one of the following "magic words" - "closes, fixes" to auto-close the Github issue. -->
* #<issue>

## Test Plan

<!-- How will this be tested prior to merging.-->
- [x] 💪 Manual
- [ ] ⚡ Unit test
- [ ] 💚 E2E
This commit is contained in:
Vaibhav Kamra 2023-01-11 23:40:49 -08:00 committed by GitHub
parent eda7a5d675
commit 5d70b4b3a6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/internal/connector/onedrive/collection.go
View File

@ -35,10 +35,10 @@ const (
) )
var ( var (
_ data.Collection = &Collection{} _ data.Collection = &Collection{}
_ data.Stream = &Item{} _ data.Stream = &Item{}
_ data.StreamInfo = &Item{} _ data.StreamInfo = &Item{}
_ data.StreamModTime = &Item{} // _ data.StreamModTime = &Item{}
) )
// Collection represents a set of OneDrive objects retrieved from M365 // Collection represents a set of OneDrive objects retrieved from M365
@ -158,9 +158,9 @@ func (od *Item) Info() details.ItemInfo {
return od.info return od.info
} }
func (od *Item) ModTime() time.Time { // func (od *Item) ModTime() time.Time {
return od.info.Modified() // return od.info.Modified()
} // }
// populateItems iterates through items added to the collection // populateItems iterates through items added to the collection
// and uses the collection `itemReader` to read the item // and uses the collection `itemReader` to read the item

6
src/internal/connector/onedrive/collection_test.go
View File

@ -179,9 +179,9 @@ func (suite *CollectionUnitTestSuite) TestCollection() {
assert.Equal(t, testItemName, readItem.UUID()) assert.Equal(t, testItemName, readItem.UUID())
require.Implements(t, (*data.StreamModTime)(nil), readItem) // require.Implements(t, (*data.StreamModTime)(nil), readItem)
mt := readItem.(data.StreamModTime) // mt := readItem.(data.StreamModTime)
assert.Equal(t, now, mt.ModTime()) // assert.Equal(t, now, mt.ModTime())
readData, err := io.ReadAll(readItem.ToReader()) readData, err := io.ReadAll(readItem.ToReader())
require.NoError(t, err) require.NoError(t, err)