larryh/corso
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Log retry after for throttled requests (#2847)

Browse Source 
This seems to be the header that is used to communicate the delay in seconds to wait.

---

#### Does this PR need a docs update or release note?

- [ ] ✅ Yes, it's included
- [ ] 🕐 Yes, but in a later PR
- [x] ⛔ No

#### Type of change

- [ ] 🌻 Feature
- [ ] 🐛 Bugfix
- [ ] 🗺️ Documentation
- [ ] 🤖 Test
- [ ] 💻 CI/Deployment
- [x] 🧹 Tech Debt/Cleanup

#### Issue(s)

* closes #2846

#### Test Plan

- [x] 💪 Manual
- [ ] ⚡ Unit test
- [ ] 💚 E2E
This commit is contained in:
ashmrtn 2023-03-17 17:14:03 -07:00 committed by GitHub
parent 621e850531
commit 60d173b25b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/internal/connector/graph/service.go
View File

@ -303,7 +303,6 @@ func (handler *LoggingMiddleware) Intercept(
// with a slimmer reference for telemetry/supportability purposes. // with a slimmer reference for telemetry/supportability purposes.
if logger.DebugAPI || os.Getenv(logGraphRequestsEnvKey) != "" { if logger.DebugAPI || os.Getenv(logGraphRequestsEnvKey) != "" {
log.Errorw("non-2xx graph api response", "response", getRespDump(ctx, resp, true)) log.Errorw("non-2xx graph api response", "response", getRespDump(ctx, resp, true))
return resp, err return resp, err
} }
@ -314,7 +313,8 @@ func (handler *LoggingMiddleware) Intercept(
log.With( log.With(
"limit", resp.Header.Get(rateLimitHeader), "limit", resp.Header.Get(rateLimitHeader),
"remaining", resp.Header.Get(rateRemainingHeader), "remaining", resp.Header.Get(rateRemainingHeader),
"reset", resp.Header.Get(rateResetHeader)) "reset", resp.Header.Get(rateResetHeader),
"retry-after", resp.Header.Get(retryAfterHeader))
} else if resp.StatusCode/100 == 4 { } else if resp.StatusCode/100 == 4 {
log.With("response", getRespDump(ctx, resp, true)) log.With("response", getRespDump(ctx, resp, true))
} }