From 6846ebf964ae3a83e6417233d28563aae770ddfb Mon Sep 17 00:00:00 2001
From: Abin Simon <abinsimon10@gmail.com>
Date: Thu, 20 Oct 2022 05:49:41 +0530
Subject: [PATCH] Skip mdgen build in case of valid mdgen in Makefile (#1214)

## Description

`_validatemdgen` resulted in the build for mdgen to always happen. This fixes that.

## Type of change

<!--- Please check the type of change your PR introduces: --->
- [ ] :sunflower: Feature
- [ ] :bug: Bugfix
- [x] :world_map: Documentation
- [ ] :robot: Test
- [x] :computer: CI/Deployment
- [ ] :hamster: Trivial/Minor

## Issue(s)

<!-- Can reference multiple issues. Use one of the following "magic words" - "closes, fixes" to auto-close the Github issue. -->
* #<issue>

## Test Plan

<!-- How will this be tested prior to merging.-->
- [x] :muscle: Manual
- [ ] :zap: Unit test
- [ ] :green_heart: E2E
---
 docs/Makefile | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/docs/Makefile b/docs/Makefile
index 4a5c6f2ae..dc3ae10dd 100644
--- a/docs/Makefile
+++ b/docs/Makefile
@@ -39,15 +39,16 @@ dockershell:
 build: genclidocs
 	$(DOCSC) npm run build
 
-genclidocs: ${MDGEN_BINARY}
+genclidocs: _validatemdgen ${MDGEN_BINARY}
 	@echo 'Auto-generating Corso CLI docs...'
 	$(DOCSC) rm -rf docs/cli
 	$(GOC) ${MDGEN_BINARY} --cli-folder ${CLI_DOCS}
 
 _validatemdgen: # in case we have a different architecture
+	@echo 'Verifying dependencies...'
 	$(GOC) ${MDGEN_BINARY} --help >/dev/null || $(GOC) rm -rf ${MDGEN_BINARY}
 
-${MDGEN_BINARY}: $(shell find ${CORSO_LOCAL_PATH}/src -type f -name *.go) $(shell find ${CORSO_LOCAL_PATH}/src -type d ) _validatemdgen
+${MDGEN_BINARY}: $(shell find ${CORSO_LOCAL_PATH}/src -type f -name *.go) $(shell find ${CORSO_LOCAL_PATH}/src -type d )
 	@echo 'Re-building Corso CLI docs auto-gen tooling...'
 		$(GOC) go mod download 
 		$(GOC) go build -o ${MDGEN_BINARY} ${MDGEN_SRC}