From 7076bc0e7f8f2ab82cd56d9ee3348d72c2f50426 Mon Sep 17 00:00:00 2001 From: Danny Adams Date: Fri, 20 Jan 2023 18:15:35 -0500 Subject: [PATCH] Updates /cli/backup/sharepoint_test.go Test suite expanded to include sharePoint data selection. --- src/cli/backup/sharepoint_test.go | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/src/cli/backup/sharepoint_test.go b/src/cli/backup/sharepoint_test.go index d568d4cc6..89e40a9f3 100644 --- a/src/cli/backup/sharepoint_test.go +++ b/src/cli/backup/sharepoint_test.go @@ -98,12 +98,13 @@ func (suite *SharePointSuite) TestValidateSharePointBackupCreateFlags() { } for _, test := range table { suite.T().Run(test.name, func(t *testing.T) { - test.expect(t, validateSharePointBackupCreateFlags(test.site, test.weburl)) + test.expect(t, validateSharePointBackupCreateFlags(test.site, test.weburl, nil)) }) } } func (suite *SharePointSuite) TestSharePointBackupCreateSelectors() { + comboString := []string{"id_1", "id_2"} gc := &connector.GraphConnector{ Sites: map[string]string{ "url_1": "id_1", @@ -115,6 +116,7 @@ func (suite *SharePointSuite) TestSharePointBackupCreateSelectors() { name string site []string weburl []string + data []string expect []string expectScopesLen int }{ @@ -163,7 +165,7 @@ func (suite *SharePointSuite) TestSharePointBackupCreateSelectors() { name: "duplicate sites and urls", site: []string{"id_1", "id_2"}, weburl: []string{"url_1", "url_2"}, - expect: []string{"id_1", "id_2"}, + expect: comboString, expectScopesLen: 2, }, { @@ -175,18 +177,25 @@ func (suite *SharePointSuite) TestSharePointBackupCreateSelectors() { }, { name: "unnecessary url wildcard", - site: []string{"id_1", "id_2"}, + site: comboString, weburl: []string{"url_1", utils.Wildcard}, expect: selectors.Any(), expectScopesLen: 2, }, + { + name: "Pages", + site: comboString, + data: []string{dataPages}, + expect: comboString, + expectScopesLen: 1, + }, } for _, test := range table { suite.T().Run(test.name, func(t *testing.T) { ctx, flush := tester.NewContext() defer flush() - sel, err := sharePointBackupCreateSelectors(ctx, test.site, test.weburl, gc) + sel, err := sharePointBackupCreateSelectors(ctx, test.site, test.weburl, test.data, gc) require.NoError(t, err) assert.ElementsMatch(t, test.expect, sel.DiscreteResourceOwners())