From 748ff803d1dc41c5e39e106327cdbeac04902c89 Mon Sep 17 00:00:00 2001 From: Abhishek Pandey Date: Fri, 21 Jul 2023 00:27:26 -0700 Subject: [PATCH] Remove a few more failing points --- src/internal/operations/backup.go | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/src/internal/operations/backup.go b/src/internal/operations/backup.go index 7ef7fd505..884dc2ec0 100644 --- a/src/internal/operations/backup.go +++ b/src/internal/operations/backup.go @@ -235,24 +235,24 @@ func (op *BackupOperation) Run(ctx context.Context) (err error) { // ----- err = op.persistResults(startTime, &opStats) - if err != nil { + if err != nil && (deets == nil || deets.Empty()) { op.Errors.Fail(clues.Wrap(err, "persisting backup results")) return op.Errors.Failure() } // force exit without backup in certain cases. // see: https://github.com/alcionai/corso/pull/2510#discussion_r1113532530 - for _, e := range op.Errors.Recovered() { - if clues.HasLabel(e, fault.LabelForceNoBackupCreation) { - logger.Ctx(ctx). - With("error", e). - With(clues.InErr(err).Slice()...). - Infow("completed backup; conditional error forcing exit without model persistence", - "results", op.Results) + // for _, e := range op.Errors.Recovered() { + // if clues.HasLabel(e, fault.LabelForceNoBackupCreation) { + // logger.Ctx(ctx). + // With("error", e). + // With(clues.InErr(err).Slice()...). + // Infow("completed backup; conditional error forcing exit without model persistence", + // "results", op.Results) - return op.Errors.Fail(clues.Wrap(e, "forced backup")).Failure() - } - } + // return op.Errors.Fail(clues.Wrap(e, "forced backup")).Failure() + // } + // } err = op.createBackupModels( ctx,