From 755db5ae9254bc3374bda98995afc8dce4cc6153 Mon Sep 17 00:00:00 2001 From: Abin Simon Date: Thu, 7 Sep 2023 13:37:07 +0530 Subject: [PATCH] Handle groups when setting currency middleware defaults (#4190) --- #### Does this PR need a docs update or release note? - [ ] :white_check_mark: Yes, it's included - [ ] :clock1: Yes, but in a later PR - [x] :no_entry: No #### Type of change - [ ] :sunflower: Feature - [x] :bug: Bugfix - [ ] :world_map: Documentation - [ ] :robot: Supportability/Tests - [ ] :computer: CI/Deployment - [ ] :broom: Tech Debt/Cleanup #### Issue(s) * # #### Test Plan - [ ] :muscle: Manual - [x] :zap: Unit test - [ ] :green_heart: E2E --- src/internal/m365/graph/concurrency_middleware.go | 3 ++- src/internal/m365/graph/middleware_test.go | 5 +++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/src/internal/m365/graph/concurrency_middleware.go b/src/internal/m365/graph/concurrency_middleware.go index f886abe5f..a9e45f17c 100644 --- a/src/internal/m365/graph/concurrency_middleware.go +++ b/src/internal/m365/graph/concurrency_middleware.go @@ -122,7 +122,8 @@ func ctxLimiter(ctx context.Context) *rate.Limiter { } switch lc.Service { - case path.OneDriveService, path.SharePointService: + // FIXME: Handle based on category once we add chat backup + case path.OneDriveService, path.SharePointService, path.GroupsService: return driveLimiter default: return defaultLimiter diff --git a/src/internal/m365/graph/middleware_test.go b/src/internal/m365/graph/middleware_test.go index d03119acf..4cc2abe2a 100644 --- a/src/internal/m365/graph/middleware_test.go +++ b/src/internal/m365/graph/middleware_test.go @@ -372,6 +372,11 @@ func (suite *MiddlewareUnitSuite) TestBindExtractLimiterConfig() { service: path.SharePointService, expectLimiter: driveLimiter, }, + { + name: "groups", + service: path.GroupsService, + expectLimiter: driveLimiter, + }, { name: "unknownService", service: path.UnknownService,