Remove duplicate recoverable err during item download (#4766)

<!-- PR description-->

We are logging a recoverable error in 2 places for the same failure during lazy item download. See the [code](6307d8cbf6/src/internal/kopia/upload.go (L228)) for the other location.  For e.g. below 2 recoverable errors are referring to the same graph 400 failure. 

`running backup: recoverable error 1 of 6: downloading item content: retrieving expired item: getting item: Invalid request: Invalid request`
`
running backup: recoverable error 2 of 6: kopia reported error: fetching item content: retrieving expired item: getting item: Invalid request: Invalid request`

Removing the duplicate since it can be confusing to the end user & devs.

---

#### Does this PR need a docs update or release note?

- [ ]  Yes, it's included
- [x] 🕐 Yes, but in a later PR
- [ ]  No

#### Type of change

<!--- Please check the type of change your PR introduces: --->
- [ ] 🌻 Feature
- [ ] 🐛 Bugfix
- [ ] 🗺️ Documentation
- [ ] 🤖 Supportability/Tests
- [ ] 💻 CI/Deployment
- [x] 🧹 Tech Debt/Cleanup

#### Issue(s)

<!-- Can reference multiple issues. Use one of the following "magic words" - "closes, fixes" to auto-close the Github issue. -->
* #<issue>

#### Test Plan

<!-- How will this be tested prior to merging.-->
- [x] 💪 Manual
- [ ]  Unit test
- [ ] 💚 E2E
This commit is contained in:
Abhishek Pandey 2023-12-01 10:33:01 -08:00 committed by GitHub
parent 6ccf32cde0
commit 79a37bfb91
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -335,14 +335,9 @@ func (oc *Collection) getDriveItemContent(
return nil, clues.Wrap(err, "inaccesible oneNote item").Label(graph.LabelsSkippable) return nil, clues.Wrap(err, "inaccesible oneNote item").Label(graph.LabelsSkippable)
} }
errs.AddRecoverable(
ctx,
clues.WrapWC(ctx, err, "downloading item content").
Label(fault.LabelForceNoBackupCreation))
// return err, not el.Err(), because the lazy reader needs to communicate to // return err, not el.Err(), because the lazy reader needs to communicate to
// the data consumer that this item is unreadable, regardless of the fault state. // the data consumer that this item is unreadable, regardless of the fault state.
return nil, clues.Wrap(err, "fetching item content") return nil, clues.Wrap(err, "downloading item content")
} }
return itemData, nil return itemData, nil