larryh/corso
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: nightly test (#4235)

Browse Source 
<!-- PR description-->

fix: group nightly test cases 

#### Does this PR need a docs update or release note?
- [ ] ⛔ No

#### Type of change

<!--- Please check the type of change your PR introduces: --->
- [ ] 🤖 Supportability/Tests

#### Issue(s)

<!-- Can reference multiple issues. Use one of the following "magic words" - "closes, fixes" to auto-close the Github issue. -->
* #<issue>

#### Test Plan

<!-- How will this be tested prior to merging.-->
- [ ] 💚 E2E
This commit is contained in:
neha_gupta 2023-09-13 22:42:43 +05:30 committed by GitHub
parent de062cd5de
commit 804131338d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
src/cli/backup/groups_e2e_test.go
View File

@ -114,14 +114,14 @@ func (suite *BackupGroupsE2ESuite) SetupSuite() {
} }
func (suite *BackupGroupsE2ESuite) TestGroupsBackupCmd_channelMessages() { func (suite *BackupGroupsE2ESuite) TestGroupsBackupCmd_channelMessages() {
runGroupsBackupCategoryTest(suite, channelMessages) runGroupsBackupCategoryTest(suite, "messages")
} }
func (suite *BackupGroupsE2ESuite) TestGroupsBackupCmd_libraries() { func (suite *BackupGroupsE2ESuite) TestGroupsBackupCmd_libraries() {
runGroupsBackupCategoryTest(suite, libraries) runGroupsBackupCategoryTest(suite, libraries.String())
} }
func runGroupsBackupCategoryTest(suite *BackupGroupsE2ESuite, category path.CategoryType) { func runGroupsBackupCategoryTest(suite *BackupGroupsE2ESuite, category string) {
recorder := strings.Builder{} recorder := strings.Builder{}
recorder.Reset() recorder.Reset()
@ -136,7 +136,7 @@ func runGroupsBackupCategoryTest(suite *BackupGroupsE2ESuite, category path.Cate
ctx, ctx,
suite.dpnd.configFilePath, suite.dpnd.configFilePath,
suite.its.group.ID, suite.its.group.ID,
category.String(), category,
&recorder) &recorder)
// run the command // run the command
@ -145,20 +145,17 @@ func runGroupsBackupCategoryTest(suite *BackupGroupsE2ESuite, category path.Cate
result := recorder.String() result := recorder.String()
t.Log("backup results", result) t.Log("backup results", result)
// as an offhand check: the result should contain the m365 group id
assert.Contains(t, result, suite.its.group.ID)
} }
func (suite *BackupGroupsE2ESuite) TestGroupsBackupCmd_groupNotFound_channelMessages() { func (suite *BackupGroupsE2ESuite) TestGroupsBackupCmd_groupNotFound_channelMessages() {
runGroupsBackupGroupNotFoundTest(suite, channelMessages) runGroupsBackupGroupNotFoundTest(suite, "messages")
} }
func (suite *BackupGroupsE2ESuite) TestGroupsBackupCmd_groupNotFound_libraries() { func (suite *BackupGroupsE2ESuite) TestGroupsBackupCmd_groupNotFound_libraries() {
runGroupsBackupGroupNotFoundTest(suite, libraries) runGroupsBackupGroupNotFoundTest(suite, libraries.String())
} }
func runGroupsBackupGroupNotFoundTest(suite *BackupGroupsE2ESuite, category path.CategoryType) { func runGroupsBackupGroupNotFoundTest(suite *BackupGroupsE2ESuite, category string) {
recorder := strings.Builder{} recorder := strings.Builder{}
recorder.Reset() recorder.Reset()
@ -173,7 +170,7 @@ func runGroupsBackupGroupNotFoundTest(suite *BackupGroupsE2ESuite, category path
ctx, ctx,
suite.dpnd.configFilePath, suite.dpnd.configFilePath,
"foo@not-there.com", "foo@not-there.com",
category.String(), category,
&recorder) &recorder)
// run the command // run the command
@ -236,12 +233,6 @@ func (suite *BackupGroupsE2ESuite) TestBackupCreateGroups_fromConfigFile() {
// run the command // run the command
err := cmd.ExecuteContext(ctx) err := cmd.ExecuteContext(ctx)
require.NoError(t, err, clues.ToCore(err)) require.NoError(t, err, clues.ToCore(err))
result := suite.dpnd.recorder.String()
t.Log("backup results", result)
// as an offhand check: the result should contain the m365 group id
assert.Contains(t, result, suite.its.group.ID)
} }
// AWS flags // AWS flags