From 81625532bb1ad241204544694f07c5df9f5e9383 Mon Sep 17 00:00:00 2001 From: ashmrtn Date: Wed, 18 Jan 2023 14:28:32 -0800 Subject: [PATCH] Delete details snapshot on backup delete (#2166) ## Description Don't leave orphaned details snapshots when a backup is being deleted. ## Does this PR need a docs update or release note? - [ ] :white_check_mark: Yes, it's included - [ ] :clock1: Yes, but in a later PR - [x] :no_entry: No ## Type of change - [ ] :sunflower: Feature - [x] :bug: Bugfix - [ ] :world_map: Documentation - [ ] :robot: Test - [ ] :computer: CI/Deployment - [ ] :broom: Tech Debt/Cleanup ## Issue(s) * closes #2152 ## Test Plan - [x] :muscle: Manual - [ ] :zap: Unit test - [ ] :green_heart: E2E --- src/pkg/repository/repository.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/pkg/repository/repository.go b/src/pkg/repository/repository.go index f8559759f..c98a037c7 100644 --- a/src/pkg/repository/repository.go +++ b/src/pkg/repository/repository.go @@ -325,6 +325,10 @@ func (r repository) DeleteBackup(ctx context.Context, id model.StableID) error { return err } + if err := r.dataLayer.DeleteSnapshot(ctx, bu.DetailsID); err != nil { + return err + } + sw := store.NewKopiaStore(r.modelStore) return sw.DeleteBackup(ctx, id)