run cli e2e on the nightly schedule, not CI (#3367)

e2e tests are large, slow, and lack configuration control
that prevents data restoration explosions.  This moves
those tests out of the standard CI and into the nightly
test suite to be run on a less frequent cadence.  The
goal is to improve CI test speed and test stability.

---

#### Does this PR need a docs update or release note?

- [x] ⛔ No

#### Type of change

- [x] 🤖 Supportability/Tests

#### Test Plan

- [x] 💚 E2E

.github/workflows/load_test.yml

@@ -1,10 +1,8 @@
 name: Nightly Load Testing
 on:
   schedule:
-    # every day at 01:59 (01:59am) UTC
+    # every day at 03:59 GMT (roughly 8pm PST)
-    # - cron: "59 1 * * *"
+    - cron: "59 3 * * *"
-    # temp, for testing: every 4 hours
-    - cron: "0 */4 * * *"
 
 permissions:
   # required to retrieve AWS credentials
@@ -20,6 +18,10 @@ jobs:
   Load-Tests:
     environment: Load Testing
     runs-on: ubuntu-latest
+    # Skipping load testing for now.  They need some love to get up and
+    # running properly, and it's better to not fight for resources with
+    # tests that are guaranteed to fail.
+    if: false
     defaults:
       run:
         working-directory: src

.github/workflows/nightly_test.yml

@@ -3,8 +3,8 @@ on:
   workflow_dispatch:
 
   schedule:
-    # Run every day at 0 minutes and 0 hours (midnight GMT)
+    # Run every day at 04:00 GMT (roughly 8pm PST)
-    - cron: "0 0 * * *"
+    - cron: "0 4 * * *"
 
 permissions:
   # required to retrieve AWS credentials
@@ -122,6 +122,7 @@ jobs:
           AZURE_CLIENT_SECRET: ${{ secrets[env.AZURE_CLIENT_SECRET_NAME] }}
           AZURE_TENANT_ID: ${{ secrets.TENANT_ID }}
           CORSO_NIGHTLY_TESTS: true
+          CORSO_E2E_TESTS: true
           CORSO_M365_TEST_USER_ID: ${{ vars.CORSO_M365_TEST_USER_ID }}
           CORSO_SECONDARY_M365_TEST_USER_ID: ${{ vars.CORSO_SECONDARY_M365_TEST_USER_ID }}
           CORSO_PASSPHRASE: ${{ secrets.INTEGRATION_TEST_CORSO_PASSPHRASE }}

src/cli/backup/exchange_e2e_test.go

@@ -54,7 +54,6 @@ func TestNoBackupExchangeE2ESuite(t *testing.T) {
 	suite.Run(t, &NoBackupExchangeE2ESuite{Suite: tester.NewE2ESuite(
 		t,
 		[][]string{tester.AWSStorageCredEnvs, tester.M365AcctCredEnvs},
-		tester.CorsoCITests,
 	)})
 }
 
@@ -120,7 +119,6 @@ func TestBackupExchangeE2ESuite(t *testing.T) {
 	suite.Run(t, &BackupExchangeE2ESuite{Suite: tester.NewE2ESuite(
 		t,
 		[][]string{tester.AWSStorageCredEnvs, tester.M365AcctCredEnvs},
-		tester.CorsoCITests,
 	)})
 }
 
@@ -235,7 +233,6 @@ func TestPreparedBackupExchangeE2ESuite(t *testing.T) {
 	suite.Run(t, &PreparedBackupExchangeE2ESuite{Suite: tester.NewE2ESuite(
 		t,
 		[][]string{tester.AWSStorageCredEnvs, tester.M365AcctCredEnvs},
-		tester.CorsoCITests,
 	)})
 }
 
@@ -490,7 +487,6 @@ func TestBackupDeleteExchangeE2ESuite(t *testing.T) {
 		Suite: tester.NewE2ESuite(
 			t,
 			[][]string{tester.AWSStorageCredEnvs, tester.M365AcctCredEnvs},
-			tester.CorsoCITests,
 		),
 	})
 }

src/cli/backup/onedrive_e2e_test.go

@@ -44,9 +44,7 @@ func TestNoBackupOneDriveE2ESuite(t *testing.T) {
 	suite.Run(t, &NoBackupOneDriveE2ESuite{
 		Suite: tester.NewE2ESuite(
 			t,
-			[][]string{tester.AWSStorageCredEnvs, tester.M365AcctCredEnvs},
+			[][]string{tester.AWSStorageCredEnvs, tester.M365AcctCredEnvs}),
-			tester.CorsoCITests,
-		),
 	})
 }
 
@@ -148,9 +146,7 @@ func TestBackupDeleteOneDriveE2ESuite(t *testing.T) {
 	suite.Run(t, &BackupDeleteOneDriveE2ESuite{
 		Suite: tester.NewE2ESuite(
 			t,
-			[][]string{tester.AWSStorageCredEnvs, tester.M365AcctCredEnvs},
+			[][]string{tester.AWSStorageCredEnvs, tester.M365AcctCredEnvs}),
-			tester.CorsoCITests,
-		),
 	})
 }
 

src/cli/backup/sharepoint_e2e_test.go

@@ -45,7 +45,6 @@ func TestNoBackupSharePointE2ESuite(t *testing.T) {
 	suite.Run(t, &NoBackupSharePointE2ESuite{Suite: tester.NewE2ESuite(
 		t,
 		[][]string{tester.AWSStorageCredEnvs, tester.M365AcctCredEnvs},
-		tester.CorsoCITests,
 	)})
 }
 
@@ -112,9 +111,7 @@ func TestBackupDeleteSharePointE2ESuite(t *testing.T) {
 	suite.Run(t, &BackupDeleteSharePointE2ESuite{
 		Suite: tester.NewE2ESuite(
 			t,
-			[][]string{tester.AWSStorageCredEnvs, tester.M365AcctCredEnvs},
+			[][]string{tester.AWSStorageCredEnvs, tester.M365AcctCredEnvs}),
-			tester.CorsoCITests,
-		),
 	})
 }
 

src/cli/repo/s3_e2e_test.go

@@ -25,7 +25,6 @@ func TestS3E2ESuite(t *testing.T) {
 	suite.Run(t, &S3E2ESuite{Suite: tester.NewE2ESuite(
 		t,
 		[][]string{tester.AWSStorageCredEnvs, tester.M365AcctCredEnvs},
-		tester.CorsoCITests,
 	)})
 }
 

src/cli/restore/exchange_e2e_test.go

@@ -48,9 +48,7 @@ func TestRestoreExchangeE2ESuite(t *testing.T) {
 	suite.Run(t, &RestoreExchangeE2ESuite{
 		Suite: tester.NewE2ESuite(
 			t,
-			[][]string{tester.AWSStorageCredEnvs, tester.M365AcctCredEnvs},
+			[][]string{tester.AWSStorageCredEnvs, tester.M365AcctCredEnvs}),
-			tester.CorsoCITests,
-		),
 	})
 }