From 9324fa113d098332940b8b9c37afb1c54615a332 Mon Sep 17 00:00:00 2001 From: Abhishek Pandey Date: Mon, 21 Aug 2023 11:30:28 +0530 Subject: [PATCH] Improve tests --- .../m365/collection/drive/url_cache_test.go | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/src/internal/m365/collection/drive/url_cache_test.go b/src/internal/m365/collection/drive/url_cache_test.go index f2fd257b8..67d672f2b 100644 --- a/src/internal/m365/collection/drive/url_cache_test.go +++ b/src/internal/m365/collection/drive/url_cache_test.go @@ -87,6 +87,7 @@ func (suite *URLCacheIntegrationSuite) TestURLCacheBasic() { newItem(newFolderName, true), control.Copy) require.NoError(t, err, clues.ToCore(err)) + require.NotNil(t, newFolder.GetId()) nfid := ptr.Val(newFolder.GetId()) @@ -131,10 +132,7 @@ func (suite *URLCacheIntegrationSuite) TestURLCacheBasic() { nfid, newItem(newItemName, false), control.Copy) - if err != nil { - // Something bad happened, skip this item - continue - } + require.NoError(t, err, clues.ToCore(err)) items = append(items, item) } @@ -176,13 +174,18 @@ func (suite *URLCacheIntegrationSuite) TestURLCacheBasic() { nil, nil) require.NoError(t, err, clues.ToCore(err)) + + require.NotNil(t, resp) + require.NotNil(t, resp.Body) require.Equal(t, http.StatusOK, resp.StatusCode) + + resp.Body.Close() }(i) } wg.Wait() - // Validate that <= 1 delta queries were made by url cache - require.LessOrEqual(t, uc.deltaQueryCount, 1) + // Validate that exactly 1 delta query was made by url cache + require.Equal(t, 1, uc.deltaQueryCount) } type URLCacheUnitSuite struct {