larryh/corso
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Minor cleanup

Browse Source
This commit is contained in:
Abhishek Pandey 2023-06-30 02:23:19 -07:00
parent 49007969cc
commit a7ae09072c
2 changed files with 3 additions and 63 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/pkg/extensions/extensions.go
View File

@ -30,7 +30,7 @@ type loggerExtension struct {
extInfo *details.ExtensionInfo
}
func NewMonitoringExtension(
func NewLoggerExtension(
ctx context.Context,
rc io.ReadCloser,
info details.ItemInfo,
@ -99,7 +99,7 @@ func (eh *ItemExtensionHandler) AddItemExtensions(
return nil, nil, clues.New("no extensions supplied")
}
factories = append(factories, NewMonitoringExtension)
factories = append(factories, NewLoggerExtension)
ctx = clues.Add(ctx, "num_extensions", len(factories))
extInfo := &details.ExtensionInfo{

62
src/pkg/extensions/extensions_test.go
View File

@ -280,64 +280,4 @@ func (suite *ExtensionsUnitSuite) TestAddItemExtensions() {
}
// TODO: tests for loggerExtension
// {
// name: "read_failure",
// factories: []CorsoItemExtensionFactory{
// func(
// ctx context.Context,
// rc io.ReadCloser,
// info details.ItemInfo,
// extInfo *details.ExtensionInfo,
// ) (CorsoItemExtension, error) {
// mockExt, _ := NewMockExtension(ctx, rc, info, extInfo)
// mockExt.failOnRead = true
// return mockExt, nil
// },
// },
// payload: []byte("some data"),
// expectedErr: require.Error,
// rc: io.NopCloser(bytes.NewReader([]byte("some data"))),
// },
// {
// name: "close_failure",
// factories: []CorsoItemExtensionFactory{
// func(
// ctx context.Context,
// rc io.ReadCloser,
// info details.ItemInfo,
// extInfo *details.ExtensionInfo,
// ) (CorsoItemExtension, error) {
// mockExt, _ := NewMockExtension(ctx, rc, info, extInfo)
// mockExt.failOnClose = true
// return mockExt, nil
// },
// },
// payload: []byte("some data"),
// expectedErr: require.Error,
// rc: io.NopCloser(bytes.NewReader([]byte("some data"))),
// },
// for _, test := range table {
// suite.Run(test.name, func() {
// t := suite.T()
// ctx, flush := tester.NewContext(t)
// defer flush()
// extRc, extInfo, err := AddItemExtensions(
// ctx,
// test.rc,
// details.ItemInfo{},
// test.factories)
// require.NoError(suite.T(), err)
// err = readFrom(extRc)
// require.NoError(suite.T(), err)
// require.Equal(suite.T(), len(test.payload), extInfo.Data["numBytes"])
// // verify crc32
// c := extInfo.Data["crc32"].(uint32)
// require.Equal(suite.T(), c, crc32.ChecksumIEEE(test.payload))
// })
// }
// TODO: Tests to verify RC wrapper ordering by AddItemExtensioner