From b3cb8fec46e986ca253816a78fe134204bb658ec Mon Sep 17 00:00:00 2001
From: Danny Adams <da469@cornell.edu>
Date: Sat, 21 Jan 2023 20:05:58 -0500
Subject: [PATCH] Updates to /conector/support/m365Support_test.go Use of
 constant for repeating test names.

---
 .../connector/support/m365Support_test.go     | 21 ++++++++++++-------
 1 file changed, 13 insertions(+), 8 deletions(-)

diff --git a/src/internal/connector/support/m365Support_test.go b/src/internal/connector/support/m365Support_test.go
index e388e6727..557a91750 100644
--- a/src/internal/connector/support/m365Support_test.go
+++ b/src/internal/connector/support/m365Support_test.go
@@ -20,6 +20,11 @@ func TestDataSupportSuite(t *testing.T) {
 	suite.Run(t, new(DataSupportSuite))
 }
 
+var (
+	empty   = "Empty Bytes"
+	invalid = "Invalid Bytes"
+)
+
 // TestCreateMessageFromBytes verifies approved mockdata bytes can
 // be successfully transformed into M365 Message data.
 func (suite *DataSupportSuite) TestCreateMessageFromBytes() {
@@ -61,13 +66,13 @@ func (suite *DataSupportSuite) TestCreateContactFromBytes() {
 		isNil      assert.ValueAssertionFunc
 	}{
 		{
-			name:       "Empty Bytes",
+			name:       empty,
 			byteArray:  make([]byte, 0),
 			checkError: assert.Error,
 			isNil:      assert.Nil,
 		},
 		{
-			name:       "Invalid Bytes",
+			name:       invalid,
 			byteArray:  []byte("A random sentence doesn't make an object"),
 			checkError: assert.Error,
 			isNil:      assert.Nil,
@@ -96,13 +101,13 @@ func (suite *DataSupportSuite) TestCreateEventFromBytes() {
 		isNil      assert.ValueAssertionFunc
 	}{
 		{
-			name:       "Empty Byes",
+			name:       empty,
 			byteArray:  make([]byte, 0),
 			checkError: assert.Error,
 			isNil:      assert.Nil,
 		},
 		{
-			name:       "Invalid Bytes",
+			name:       invalid,
 			byteArray:  []byte("Invalid byte stream \"subject:\" Not going to work"),
 			checkError: assert.Error,
 			isNil:      assert.Nil,
@@ -134,13 +139,13 @@ func (suite *DataSupportSuite) TestCreateListFromBytes() {
 		isNil      assert.ValueAssertionFunc
 	}{
 		{
-			name:       "Empty Bytes",
+			name:       empty,
 			byteArray:  make([]byte, 0),
 			checkError: assert.Error,
 			isNil:      assert.Nil,
 		},
 		{
-			name:       "Invalid Bytes",
+			name:       invalid,
 			byteArray:  []byte("Invalid byte stream \"subject:\" Not going to work"),
 			checkError: assert.Error,
 			isNil:      assert.Nil,
@@ -170,7 +175,7 @@ func (suite *DataSupportSuite) TestCreatePageFromBytes() {
 		getBytes   func(t *testing.T) []byte
 	}{
 		{
-			"Empty Bytes",
+			empty,
 			assert.Error,
 			assert.Nil,
 			func(t *testing.T) []byte {
@@ -178,7 +183,7 @@ func (suite *DataSupportSuite) TestCreatePageFromBytes() {
 			},
 		},
 		{
-			"Invalid Bytes",
+			invalid,
 			assert.Error,
 			assert.Nil,
 			func(t *testing.T) []byte {