From b6a7095c7f5c8ac6f9a538b217051a1f955ddf22 Mon Sep 17 00:00:00 2001
From: ashmrtn <ashmrtnz@alcion.ai>
Date: Mon, 23 Jan 2023 10:35:16 -0800
Subject: [PATCH] Don't retry if an item was not found (#2233)

## Description

When fetching item data, don't backoff and retry if Graph reported the item was not found. In this case, we mark it as succeeded as we can never get the data anyway.

## Does this PR need a docs update or release note?

- [ ] :white_check_mark: Yes, it's included
- [ ] :clock1: Yes, but in a later PR
- [x] :no_entry: No

## Type of change

- [ ] :sunflower: Feature
- [x] :bug: Bugfix
- [ ] :world_map: Documentation
- [ ] :robot: Test
- [ ] :computer: CI/Deployment
- [x] :broom: Tech Debt/Cleanup

## Issue(s)

* closes #2217

## Test Plan

- [x] :muscle: Manual
- [ ] :zap: Unit test
- [ ] :green_heart: E2E
---
 .../exchange/exchange_data_collection.go      | 28 +++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/src/internal/connector/exchange/exchange_data_collection.go b/src/internal/connector/exchange/exchange_data_collection.go
index e168ed082..ce37beab6 100644
--- a/src/internal/connector/exchange/exchange_data_collection.go
+++ b/src/internal/connector/exchange/exchange_data_collection.go
@@ -257,6 +257,24 @@ func (col *Collection) streamItems(ctx context.Context) {
 					break
 				}
 
+				// If the data is no longer available just return here and chalk it up
+				// as a success. There's no reason to retry and no way we can backup up
+				// enough information to restore the item anyway.
+				if e := graph.IsErrDeletedInFlight(err); e != nil {
+					atomic.AddInt64(&success, 1)
+					logger.Ctx(ctx).Infow(
+						"Graph reported item not found",
+						"error",
+						e,
+						"service",
+						path.ExchangeService.String(),
+						"category",
+						col.category.String,
+					)
+
+					return
+				}
+
 				if i < numberOfRetries {
 					time.Sleep(time.Duration(3*(i+1)) * time.Second)
 				}
@@ -270,6 +288,16 @@ func (col *Collection) streamItems(ctx context.Context) {
 				// attempted items.
 				if e := graph.IsErrDeletedInFlight(err); e != nil {
 					atomic.AddInt64(&success, 1)
+					logger.Ctx(ctx).Infow(
+						"Graph reported item not found",
+						"error",
+						e,
+						"service",
+						path.ExchangeService.String(),
+						"category",
+						col.category.String,
+					)
+
 					return
 				}