From b6c7488c0142560bf6c91b7f9c2ff3b49b78f0a6 Mon Sep 17 00:00:00 2001 From: Georgi Matev Date: Fri, 2 Sep 2022 18:59:37 -0400 Subject: [PATCH] Fix Gulp not exiting with Ctrl-C and annoying browsersync warning (#751) ## Description (1) Fix Gupl not exiting with Ctrl-C and (2) annoying browsersync warning - (1) make sure `gulp` is not PID 1 in container. Add `--init` option - (2) set `open: false` Please check the type of change your PR introduces: - [ ] :sunflower: Feature - [x] :bug: Bugfix - [ ] :world_map: Documentation - [ ] :robot: Test - [ ] :hamster: Trivial/Minor ## Issue(s) ## Test Plan - [x] :muscle: Manual - [ ] :zap: Unit test - [ ] :green_heart: E2E --- website/Makefile | 8 ++++---- website/gulpfile.js | 1 + 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/website/Makefile b/website/Makefile index 1c3aec3ac..470b0c2cf 100644 --- a/website/Makefile +++ b/website/Makefile @@ -4,15 +4,15 @@ buildimage: docker build -t "corso/website:latest" . dev: - docker run --rm -it -p 3000:3000 \ - -v ${PWD}:/usr/src/website corso/website gulp + docker run --rm -it --init -p 3000:3000 -p 3001:3001 \ + -v ${PWD}:/usr/src/website corso/website gulp shell: - docker run --rm -it -p 3000:3000 \ + docker run --rm -it -p 3000:3000 -p 3001:3001 \ -v ${PWD}:/usr/src/website corso/website /bin/bash build: - docker run --rm -it \ + docker run --rm -it --init \ -v ${PWD}:/usr/src/website corso/website gulp build publish: build diff --git a/website/gulpfile.js b/website/gulpfile.js index f72760567..db1245f1d 100644 --- a/website/gulpfile.js +++ b/website/gulpfile.js @@ -90,6 +90,7 @@ gulp.task('browsersync', function (callback) { server: { baseDir: [paths.dist.base.dir, paths.src.base.dir, paths.base.base.dir] }, + open: false, }); callback(); });