Helper function to add common backup flags (#4557)

Helps ensure that all services implement the same standard flag set and allows easily expanding said flag set.

Existing tests check flags are added as expected

---

#### Does this PR need a docs update or release note?

- [ ]  Yes, it's included
- [ ] 🕐 Yes, but in a later PR
- [x]  No

#### Type of change

- [ ] 🌻 Feature
- [ ] 🐛 Bugfix
- [ ] 🗺️ Documentation
- [ ] 🤖 Supportability/Tests
- [ ] 💻 CI/Deployment
- [x] 🧹 Tech Debt/Cleanup

#### Test Plan

- [ ] 💪 Manual
- [x]  Unit test
- [ ] 💚 E2E
This commit is contained in:
ashmrtn 2023-10-27 08:51:56 -07:00 committed by GitHub
parent d6047d3f63
commit be07a04f66
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 15 additions and 12 deletions

View File

@ -80,13 +80,11 @@ func addExchangeCommands(cmd *cobra.Command) *cobra.Command {
flags.AddMailBoxFlag(c)
flags.AddDataFlag(c, []string{dataEmail, dataContacts, dataEvents}, false)
flags.AddFetchParallelismFlag(c)
flags.AddFailFastFlag(c)
flags.AddDisableIncrementalsFlag(c)
flags.AddForceItemDataDownloadFlag(c)
flags.AddDisableDeltaFlag(c)
flags.AddEnableImmutableIDFlag(c)
flags.AddDisableConcurrencyLimiterFlag(c)
flags.AddDeltaPageSizeFlag(c)
flags.AddGenericBackupFlags(c)
case listCommand:
c, fs = utils.AddCommand(cmd, exchangeListCmd())

View File

@ -73,10 +73,8 @@ func addGroupsCommands(cmd *cobra.Command) *cobra.Command {
flags.AddGroupFlag(c)
flags.AddDataFlag(c, []string{flags.DataLibraries, flags.DataMessages}, false)
flags.AddFetchParallelismFlag(c)
flags.AddFailFastFlag(c)
flags.AddDisableDeltaFlag(c)
flags.AddDisableIncrementalsFlag(c)
flags.AddForceItemDataDownloadFlag(c)
flags.AddGenericBackupFlags(c)
case listCommand:
c, fs = utils.AddCommand(cmd, groupsListCmd(), utils.MarkPreviewCommand())

View File

@ -66,9 +66,7 @@ func addOneDriveCommands(cmd *cobra.Command) *cobra.Command {
c.Example = oneDriveServiceCommandCreateExamples
flags.AddUserFlag(c)
flags.AddFailFastFlag(c)
flags.AddDisableIncrementalsFlag(c)
flags.AddForceItemDataDownloadFlag(c)
flags.AddGenericBackupFlags(c)
case listCommand:
c, fs = utils.AddCommand(cmd, oneDriveListCmd())

View File

@ -79,9 +79,7 @@ func addSharePointCommands(cmd *cobra.Command) *cobra.Command {
flags.AddSiteFlag(c, true)
flags.AddSiteIDFlag(c, true)
flags.AddDataFlag(c, []string{flags.DataLibraries}, true)
flags.AddFailFastFlag(c)
flags.AddDisableIncrementalsFlag(c)
flags.AddForceItemDataDownloadFlag(c)
flags.AddGenericBackupFlags(c)
case listCommand:
c, fs = utils.AddCommand(cmd, sharePointListCmd())

View File

@ -0,0 +1,11 @@
package flags
import (
"github.com/spf13/cobra"
)
func AddGenericBackupFlags(cmd *cobra.Command) {
AddFailFastFlag(cmd)
AddDisableIncrementalsFlag(cmd)
AddForceItemDataDownloadFlag(cmd)
}