From c0cd7cf2f6097b3bb9143216a4761d5fcd6b9c6e Mon Sep 17 00:00:00 2001 From: Keepers Date: Mon, 16 Oct 2023 11:15:30 -0600 Subject: [PATCH] turn off exchange kopia assists (#4503) Protective measure to prevent further details merging issues. will need a follow-up to enable via a feature flag for testing. --- #### Does this PR need a docs update or release note? - [x] :no_entry: No #### Type of change - [x] :bug: Bugfix #### Issues - #2023 #### Test Plan - [x] :zap: Unit test - [x] :green_heart: E2E --- src/internal/m365/collection/exchange/backup.go | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/internal/m365/collection/exchange/backup.go b/src/internal/m365/collection/exchange/backup.go index 87db96312..62e5ac9da 100644 --- a/src/internal/m365/collection/exchange/backup.go +++ b/src/internal/m365/collection/exchange/backup.go @@ -160,7 +160,7 @@ func populateCollections( ictx = clues.Add(ictx, "previous_path", prevPath) - added, validModTimes, removed, newDelta, err := bh.itemEnumerator(). + added, _, removed, newDelta, err := bh.itemEnumerator(). GetAddedAndRemovedItemIDs( ictx, qp.ProtectedResource.ID(), @@ -199,7 +199,11 @@ func populateCollections( bh.itemHandler(), added, removed, - validModTimes, + // TODO: produce a feature flag that allows selective + // enabling of valid modTimes. This currently produces + // rare-case failures with incorrect details merging. + // Root cause is not yet known. + false, statusUpdater) collections[cID] = edc