larryh/corso
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove extra Graph API call

Browse Source
This commit is contained in:
Vaibhav Kamra 2023-03-07 19:00:25 -08:00
parent fe0642c88d
commit c2330e7262
1 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/internal/connector/onedrive/collection.go
View File

@ -333,13 +333,17 @@ func (oc *Collection) populateItems(ctx context.Context, errs *fault.Bus) {
"backup_item_size", itemSize,
)
pr, err := fetchParentReference(ctx, oc.service, item.GetParentReference())
if err != nil {
el.AddRecoverable(clues.Wrap(err, "getting parent reference").Label(fault.LabelForceNoBackupCreation))
return
}
// TODO: Removing the logic below because it introduces an extra Graph API call for
// every item being backed up. This can lead to throttling errors.
//
// pr, err := fetchParentReference(ctx, oc.service, item.GetParentReference())
// if err != nil {
// el.AddRecoverable(clues.Wrap(err, "getting parent reference").Label(fault.LabelForceNoBackupCreation))
// return
// }
// item.SetParentReference(pr)
item.SetParentReference(pr)
isFile := item.GetFile() != nil
if isFile {