From c4b2de5c6cee28350d105f27768ac28b08cd994e Mon Sep 17 00:00:00 2001 From: ashmrtn Date: Sat, 4 Feb 2023 14:17:21 -0800 Subject: [PATCH] Fix test failures when run without env vars (#2356) ## Description Either skip tests that require env vars or have them use mock credentials if they don't need access to external services. ## Does this PR need a docs update or release note? - [ ] :white_check_mark: Yes, it's included - [ ] :clock1: Yes, but in a later PR - [x] :no_entry: No ## Type of change - [ ] :sunflower: Feature - [ ] :bug: Bugfix - [ ] :world_map: Documentation - [x] :robot: Test - [ ] :computer: CI/Deployment - [x] :broom: Tech Debt/Cleanup ## Issue(s) * closes #2354 ## Test Plan - [x] :muscle: Manual - [ ] :zap: Unit test - [ ] :green_heart: E2E --- src/internal/connector/discovery/api/beta_service_test.go | 2 +- src/internal/connector/graph/betasdk/beta_client_test.go | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/src/internal/connector/discovery/api/beta_service_test.go b/src/internal/connector/discovery/api/beta_service_test.go index ad67b3877..1a0925e96 100644 --- a/src/internal/connector/discovery/api/beta_service_test.go +++ b/src/internal/connector/discovery/api/beta_service_test.go @@ -22,7 +22,7 @@ func TestBetaUnitSuite(t *testing.T) { func (suite *BetaUnitSuite) TestBetaService_Adapter() { t := suite.T() - a := tester.NewM365Account(t) + a := tester.NewMockM365Account(t) m365, err := a.M365Config() require.NoError(t, err) diff --git a/src/internal/connector/graph/betasdk/beta_client_test.go b/src/internal/connector/graph/betasdk/beta_client_test.go index 84f2db6c5..b52d000a4 100644 --- a/src/internal/connector/graph/betasdk/beta_client_test.go +++ b/src/internal/connector/graph/betasdk/beta_client_test.go @@ -18,6 +18,12 @@ type BetaClientSuite struct { } func TestBetaClientSuite(t *testing.T) { + tester.RunOnAny( + t, + tester.CorsoCITests, + tester.CorsoGraphConnectorTests, + ) + suite.Run(t, new(BetaClientSuite)) }