Add CI to check for trailing comma (#4214)

Failing run: https://github.com/alcionai/corso/actions/runs/6143208025/job/16666243728

Follow up to https://github.com/alcionai/corso/pull/4208

---

#### Does this PR need a docs update or release note?

- [ ] ✅ Yes, it's included
- [ ] 🕐 Yes, but in a later PR
- [x] ⛔ No

#### Type of change

<!--- Please check the type of change your PR introduces: --->
- [ ] 🌻 Feature
- [ ] 🐛 Bugfix
- [ ] 🗺️ Documentation
- [ ] 🤖 Supportability/Tests
- [x] 💻 CI/Deployment
- [ ] 🧹 Tech Debt/Cleanup

#### Issue(s)

<!-- Can reference multiple issues. Use one of the following "magic words" - "closes, fixes" to auto-close the Github issue. -->
* #<issue>

#### Test Plan

<!-- How will this be tested prior to merging.-->
- [ ] 💪 Manual
- [ ] ⚡ Unit test
- [ ] 💚 E2E

.github/workflows/ci.yml

@@ -489,6 +489,20 @@ jobs:
           go install github.com/ashmrtn/allowtags@latest
           allowtags --allow-key json --allow-key uriparametername ./...
 
+      # I could not find a way to install tree-grepper without nix
+      # https://github.com/BrianHicks/tree-grepper/issues/293
+      - uses: cachix/install-nix-action@v22
+      - uses: cachix/cachix-action@v12
+        with:
+            name: tree-grepper
+      - run: nix-env -if https://github.com/BrianHicks/tree-grepper/archive/refs/heads/main.tar.gz
+      - name: Run trailing comma lint rule
+        run: |
+          # Using `grep .` as the exit codes are always true for correct grammar
+          if tree-grepper -q go '(argument_list "," @no-trailing-comma .)' | grep .; then
+            echo "No trailing commas for function calls"
+            exit 1
+          fi
 
   # ----------------------------------------------------------------------------------------------------
   # --- GitHub Actions Linting -------------------------------------------------------------------------

src/cli/backup/groups_e2e_test.go

@@ -46,8 +46,7 @@ type NoBackupGroupsE2ESuite struct {
 func TestNoBackupGroupsE2ESuite(t *testing.T) {
 	suite.Run(t, &BackupGroupsE2ESuite{Suite: tester.NewE2ESuite(
 		t,
-		[][]string{storeTD.AWSStorageCredEnvs, tconfig.M365AcctCredEnvs},
+		[][]string{storeTD.AWSStorageCredEnvs, tconfig.M365AcctCredEnvs})})
-	)})
 }
 
 func (suite *NoBackupGroupsE2ESuite) SetupSuite() {
@@ -101,8 +100,7 @@ type BackupGroupsE2ESuite struct {
 func TestBackupGroupsE2ESuite(t *testing.T) {
 	suite.Run(t, &BackupGroupsE2ESuite{Suite: tester.NewE2ESuite(
 		t,
-		[][]string{storeTD.AWSStorageCredEnvs, tconfig.M365AcctCredEnvs},
+		[][]string{storeTD.AWSStorageCredEnvs, tconfig.M365AcctCredEnvs})})
-	)})
 }
 
 func (suite *BackupGroupsE2ESuite) SetupSuite() {
@@ -259,8 +257,7 @@ func (suite *BackupGroupsE2ESuite) TestBackupCreateGroups_badAWSFlags() {
 		"backup", "create", "groups",
 		"--group", suite.its.group.ID,
 		"--aws-access-key", "invalid-value",
-		"--aws-secret-access-key", "some-invalid-value",
+		"--aws-secret-access-key", "some-invalid-value")
-	)
 	cli.BuildCommandTree(cmd)
 
 	cmd.SetOut(&suite.dpnd.recorder)
@@ -517,8 +514,7 @@ func TestBackupDeleteGroupsE2ESuite(t *testing.T) {
 	suite.Run(t, &BackupDeleteGroupsE2ESuite{
 		Suite: tester.NewE2ESuite(
 			t,
-			[][]string{storeTD.AWSStorageCredEnvs, tconfig.M365AcctCredEnvs},
+			[][]string{storeTD.AWSStorageCredEnvs, tconfig.M365AcctCredEnvs}),
-		),
 	})
 }
 

src/cli/backup/teams_e2e_test.go

@@ -41,8 +41,7 @@ type NoBackupTeamsE2ESuite struct {
 func TestNoBackupTeamsE2ESuite(t *testing.T) {
 	suite.Run(t, &BackupTeamsE2ESuite{Suite: tester.NewE2ESuite(
 		t,
-		[][]string{storeTD.AWSStorageCredEnvs, tconfig.M365AcctCredEnvs},
+		[][]string{storeTD.AWSStorageCredEnvs, tconfig.M365AcctCredEnvs})})
-	)})
 }
 
 func (suite *NoBackupTeamsE2ESuite) SetupSuite() {
@@ -96,8 +95,7 @@ type BackupTeamsE2ESuite struct {
 func TestBackupTeamsE2ESuite(t *testing.T) {
 	suite.Run(t, &BackupTeamsE2ESuite{Suite: tester.NewE2ESuite(
 		t,
-		[][]string{storeTD.AWSStorageCredEnvs, tconfig.M365AcctCredEnvs},
+		[][]string{storeTD.AWSStorageCredEnvs, tconfig.M365AcctCredEnvs})})
-	)})
 }
 
 func (suite *BackupTeamsE2ESuite) SetupSuite() {
@@ -254,8 +252,7 @@ func (suite *BackupTeamsE2ESuite) TestBackupCreateTeams_badAWSFlags() {
 		"backup", "create", "teams",
 		"--team", suite.its.team.ID,
 		"--aws-access-key", "invalid-value",
-		"--aws-secret-access-key", "some-invalid-value",
+		"--aws-secret-access-key", "some-invalid-value")
-	)
 	cli.BuildCommandTree(cmd)
 
 	cmd.SetOut(&suite.dpnd.recorder)
@@ -512,8 +509,7 @@ func TestBackupDeleteTeamsE2ESuite(t *testing.T) {
 	suite.Run(t, &BackupDeleteTeamsE2ESuite{
 		Suite: tester.NewE2ESuite(
 			t,
-			[][]string{storeTD.AWSStorageCredEnvs, tconfig.M365AcctCredEnvs},
+			[][]string{storeTD.AWSStorageCredEnvs, tconfig.M365AcctCredEnvs}),
-		),
 	})
 }