From dea84eeb37c2b68a3998a2cc7a2189a8728daa4f Mon Sep 17 00:00:00 2001
From: ryanfkeepers <ryanfkeepers@gmail.com>
Date: Fri, 5 May 2023 10:07:51 -0600
Subject: [PATCH] add back link to sp perms docs

---
 src/internal/connector/onedrive/item.go | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/internal/connector/onedrive/item.go b/src/internal/connector/onedrive/item.go
index 0dbac6508..5fd2fa737 100644
--- a/src/internal/connector/onedrive/item.go
+++ b/src/internal/connector/onedrive/item.go
@@ -241,6 +241,9 @@ func filterUserPermissions(ctx context.Context, perms []models.Permissionable) [
 		// write - Design | Edit | Contribute (no difference in /permissions api)
 		// read  - Read
 		// empty - Restricted View
+		//
+		// helpful docs:
+		// https://devblogs.microsoft.com/microsoft365dev/controlling-app-access-on-specific-sharepoint-site-collections/
 		roles := p.GetRoles()
 
 		entityID := ""
@@ -253,12 +256,12 @@ func filterUserPermissions(ctx context.Context, perms []models.Permissionable) [
 
 			if gv2.GetApplication() != nil {
 				entityID = ptr.Val(gv2.GetApplication().GetId())
-			} else if gv2.GetDevice() != nil {
-				entityID = ptr.Val(gv2.GetDevice().GetId())
 			}
+
 			if gv2.GetDevice() != nil {
 				logm.With("device_id", ptr.Val(gv2.GetDevice().GetId()))
 			}
+
 			logm.Info("untracked permission")
 		}