larryh/corso
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Makefile should pick up any changes in /src subfolder not just first level (#777)

Browse Source 
## Description

Globs not picking up changes to anything beyond first level of source files and not rebuilding on changes to mdgen.go for example. Switch to `find` which should also be more portable.


## Type of change

Please check the type of change your PR introduces:
- [ ] 🌻 Feature
- [x] 🐛 Bugfix
- [ ] 🗺️ Documentation
- [ ] 🤖 Test
- [ ] 🐹 Trivial/Minor

## Issue(s)


## Test Plan

<!-- How will this be tested prior to merging.-->

- [x] 💪 Manual
- [ ] ⚡ Unit test
- [ ] 💚 E2E
This commit is contained in:
Georgi Matev 2022-09-06 13:59:43 -04:00 committed by GitHub
parent 290080d865
commit f72b1e9935
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
docs/Makefile
View File

@ -52,7 +52,7 @@ genclidocs: ${MDGEN_BINARY}
golang:1.18 \ golang:1.18 \
--cli-folder ${CLI_DOCS_CONTAINER} --cli-folder ${CLI_DOCS_CONTAINER}
${MDGEN_BINARY}: ${CORSO_REPO}/src/** ${CORSO_REPO}/src/**/*.go ${MDGEN_BINARY}: $(shell find ../src -type f -name *.go) $(shell find ../src -type d )
@echo 'Re-building Corso CLI docs auto-gen tooling...' @echo 'Re-building Corso CLI docs auto-gen tooling...'
docker run --rm -it \ docker run --rm -it \
-v ${CORSO_REPO}:${CORSO_REPO_CONTAINER} -v ${CORSO_BUILD_DIR}:${CORSO_BUILD_DIR} \ -v ${CORSO_REPO}:${CORSO_REPO_CONTAINER} -v ${CORSO_BUILD_DIR}:${CORSO_BUILD_DIR} \