From ff715f4d6b5c9bc14c572e9ea45f94b8df960029 Mon Sep 17 00:00:00 2001 From: Danny Date: Tue, 6 Dec 2022 15:48:48 -0500 Subject: [PATCH] OneDrive: TestOneDriveDriveSuite/TestCreateGetDeleteFolder Sub-Test ignored (#1690) ## Description OneDrive Test experienced different results locally than in CI. Test to be ignored until a consistent test can replace it. ## Type of change - [x] :bug: Bugfix ## Issue(s) related to * #1688 ## Test Plan - [x] :zap: Unit test --- src/internal/connector/onedrive/drive_test.go | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/internal/connector/onedrive/drive_test.go b/src/internal/connector/onedrive/drive_test.go index 9b8515f65..9adcd0e5a 100644 --- a/src/internal/connector/onedrive/drive_test.go +++ b/src/internal/connector/onedrive/drive_test.go @@ -48,6 +48,7 @@ func (suite *OneDriveSuite) TestCreateGetDeleteFolder() { require.NoError(t, err) require.NotEmpty(t, drives) + // TODO: Verify the intended drive driveID := *drives[0].GetId() defer func() { @@ -88,12 +89,17 @@ func (suite *OneDriveSuite) TestCreateGetDeleteFolder() { for _, test := range table { suite.T().Run(test.name, func(t *testing.T) { + if test.name == "NoPrefix" { + // TODO: Issue #1688 + t.Skipf("Inconsistent test. Skipping until test is refactored") + } allFolders, err := GetAllFolders(ctx, gs, suite.userID, test.prefix) require.NoError(t, err) foundFolderIDs := []string{} for _, f := range allFolders { + if *f.GetName() == folderName1 || *f.GetName() == folderName2 { foundFolderIDs = append(foundFolderIDs, *f.GetId()) }