Compare commits

...

1 Commits

Author SHA1 Message Date
Abhishek Pandey
b389f57157 Add req logging 2023-12-06 16:29:52 -08:00
2 changed files with 28 additions and 0 deletions

View File

@ -42,6 +42,14 @@ func logResp(ctx context.Context, resp *http.Response) {
return
}
// Dump both request and response for graph 400 errors. This is a temporary
// measure to help us understand why graph is returning transient 400s.
if resp.StatusCode == http.StatusBadRequest {
log.With("request", getRequestDump(ctx, resp.Request, true)).
With("response", getRespDump(ctx, resp, logBody)).
Info("graph api bad request")
}
// Log api calls according to api debugging configurations.
switch respClass {
case 2:
@ -61,6 +69,15 @@ func logResp(ctx context.Context, resp *http.Response) {
}
}
func logReq(ctx context.Context, req *http.Request) {
var (
log = logger.Ctx(ctx)
)
log.With("request", getRequestDump(ctx, req, true)).
Info("graph api req")
}
func getRespDump(ctx context.Context, resp *http.Response, getBody bool) string {
respDump, err := httputil.DumpResponse(resp, getBody)
if err != nil {
@ -69,3 +86,12 @@ func getRespDump(ctx context.Context, resp *http.Response, getBody bool) string
return string(respDump)
}
func getRequestDump(ctx context.Context, req *http.Request, getBody bool) string {
reqDump, err := httputil.DumpRequest(req, getBody)
if err != nil {
logger.CtxErr(ctx, err).Error("dumping http request")
}
return string(reqDump)
}

View File

@ -118,6 +118,8 @@ func (mw *LoggingMiddleware) Intercept(
middlewareIndex int,
req *http.Request,
) (*http.Response, error) {
logReq(req.Context(), req)
// call the next middleware
resp, err := pipeline.Next(req, middlewareIndex)
if resp == nil {