In order to retrieve all clues structured error data in tests, we need to extract it from the error using the clues library. This change appends `clues.ToCore(err)` to all variations of `assert.NoError(t, err)`. The only other changes are those necessary to preserve linting, or to produce an error variable for the ToCore call. --- #### Does this PR need a docs update or release note? - [x] ⛔ No #### Type of change - [x] 🤖 Test - [x] 🧹 Tech Debt/Cleanup #### Issue(s) * #1970 #### Test Plan - [x] ⚡ Unit test - [x] 💚 E2E
53 lines
1.3 KiB
Go
53 lines
1.3 KiB
Go
package operations
|
|
|
|
import (
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/suite"
|
|
|
|
"github.com/alcionai/clues"
|
|
"github.com/alcionai/corso/src/internal/events"
|
|
"github.com/alcionai/corso/src/internal/kopia"
|
|
"github.com/alcionai/corso/src/internal/tester"
|
|
"github.com/alcionai/corso/src/pkg/control"
|
|
"github.com/alcionai/corso/src/pkg/store"
|
|
)
|
|
|
|
type OperationSuite struct {
|
|
tester.Suite
|
|
}
|
|
|
|
func TestOperationSuite(t *testing.T) {
|
|
suite.Run(t, &OperationSuite{Suite: tester.NewUnitSuite(t)})
|
|
}
|
|
|
|
func (suite *OperationSuite) TestNewOperation() {
|
|
t := suite.T()
|
|
op := newOperation(control.Options{}, events.Bus{}, nil, nil)
|
|
assert.Greater(t, op.CreatedAt, time.Time{})
|
|
}
|
|
|
|
func (suite *OperationSuite) TestOperation_Validate() {
|
|
kwStub := &kopia.Wrapper{}
|
|
swStub := &store.Wrapper{}
|
|
|
|
table := []struct {
|
|
name string
|
|
kw *kopia.Wrapper
|
|
sw *store.Wrapper
|
|
errCheck assert.ErrorAssertionFunc
|
|
}{
|
|
{"good", kwStub, swStub, assert.NoError},
|
|
{"missing kopia wrapper", nil, swStub, assert.Error},
|
|
{"missing store wrapper", kwStub, nil, assert.Error},
|
|
}
|
|
for _, test := range table {
|
|
suite.Run(test.name, func() {
|
|
err := newOperation(control.Options{}, events.Bus{}, test.kw, test.sw).validate()
|
|
test.errCheck(suite.T(), err, clues.ToCore(err))
|
|
})
|
|
}
|
|
}
|