corrects the storage and provider flag positioning to attach to the child command instead of the parent. Also corrects unit tests for flags to ensure flags are preset as expected. --- #### Does this PR need a docs update or release note? - [x] ⛔ No #### Type of change - [x] 🐛 Bugfix #### Test Plan - [x] ⚡ Unit test - [x] 💚 E2E
278 lines
6.9 KiB
Go
278 lines
6.9 KiB
Go
package backup
|
|
|
|
import (
|
|
"fmt"
|
|
"testing"
|
|
|
|
"github.com/alcionai/clues"
|
|
"github.com/spf13/cobra"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
"github.com/stretchr/testify/suite"
|
|
|
|
"github.com/alcionai/corso/src/cli/flags"
|
|
flagsTD "github.com/alcionai/corso/src/cli/flags/testdata"
|
|
cliTD "github.com/alcionai/corso/src/cli/testdata"
|
|
"github.com/alcionai/corso/src/cli/utils"
|
|
utilsTD "github.com/alcionai/corso/src/cli/utils/testdata"
|
|
"github.com/alcionai/corso/src/internal/tester"
|
|
"github.com/alcionai/corso/src/internal/version"
|
|
dtd "github.com/alcionai/corso/src/pkg/backup/details/testdata"
|
|
"github.com/alcionai/corso/src/pkg/control"
|
|
)
|
|
|
|
type OneDriveUnitSuite struct {
|
|
tester.Suite
|
|
}
|
|
|
|
func TestOneDriveUnitSuite(t *testing.T) {
|
|
suite.Run(t, &OneDriveUnitSuite{Suite: tester.NewUnitSuite(t)})
|
|
}
|
|
|
|
func (suite *OneDriveUnitSuite) TestAddOneDriveCommands() {
|
|
expectUse := oneDriveServiceCommand
|
|
|
|
table := []struct {
|
|
name string
|
|
use string
|
|
expectUse string
|
|
expectShort string
|
|
expectRunE func(*cobra.Command, []string) error
|
|
}{
|
|
{
|
|
name: "create onedrive",
|
|
use: createCommand,
|
|
expectUse: expectUse + " " + oneDriveServiceCommandCreateUseSuffix,
|
|
expectShort: oneDriveCreateCmd().Short,
|
|
expectRunE: createOneDriveCmd,
|
|
},
|
|
{
|
|
name: "list onedrive",
|
|
use: listCommand,
|
|
expectUse: expectUse,
|
|
expectShort: oneDriveListCmd().Short,
|
|
expectRunE: listOneDriveCmd,
|
|
},
|
|
{
|
|
name: "details onedrive",
|
|
use: detailsCommand,
|
|
expectUse: expectUse + " " + oneDriveServiceCommandDetailsUseSuffix,
|
|
expectShort: oneDriveDetailsCmd().Short,
|
|
expectRunE: detailsOneDriveCmd,
|
|
},
|
|
{
|
|
name: "delete onedrive",
|
|
use: deleteCommand,
|
|
expectUse: expectUse + " " + oneDriveServiceCommandDeleteUseSuffix,
|
|
expectShort: oneDriveDeleteCmd().Short,
|
|
expectRunE: deleteOneDriveCmd,
|
|
},
|
|
}
|
|
|
|
for _, test := range table {
|
|
suite.Run(test.name, func() {
|
|
t := suite.T()
|
|
|
|
cmd := &cobra.Command{Use: test.use}
|
|
|
|
c := addOneDriveCommands(cmd)
|
|
require.NotNil(t, c)
|
|
|
|
cmds := cmd.Commands()
|
|
require.Len(t, cmds, 1)
|
|
|
|
child := cmds[0]
|
|
assert.Equal(t, test.expectUse, child.Use)
|
|
assert.Equal(t, test.expectShort, child.Short)
|
|
tester.AreSameFunc(t, test.expectRunE, child.RunE)
|
|
})
|
|
}
|
|
}
|
|
|
|
func (suite *OneDriveUnitSuite) TestBackupCreateFlags() {
|
|
t := suite.T()
|
|
|
|
cmd := cliTD.SetUpCmdHasFlags(
|
|
t,
|
|
&cobra.Command{Use: createCommand},
|
|
addOneDriveCommands,
|
|
[]cliTD.UseCobraCommandFn{
|
|
flags.AddAllProviderFlags,
|
|
flags.AddAllStorageFlags,
|
|
},
|
|
flagsTD.WithFlags(
|
|
oneDriveServiceCommand,
|
|
[]string{
|
|
"--" + flags.RunModeFN, flags.RunModeFlagTest,
|
|
"--" + flags.UserFN, flagsTD.FlgInputs(flagsTD.UsersInput),
|
|
"--" + flags.FailFastFN,
|
|
"--" + flags.DisableIncrementalsFN,
|
|
"--" + flags.ForceItemDataDownloadFN,
|
|
},
|
|
flagsTD.PreparedProviderFlags(),
|
|
flagsTD.PreparedStorageFlags()))
|
|
|
|
opts := utils.MakeOneDriveOpts(cmd)
|
|
co := utils.Control()
|
|
|
|
assert.ElementsMatch(t, flagsTD.UsersInput, opts.Users)
|
|
assert.Equal(t, control.FailFast, co.FailureHandling)
|
|
assert.True(t, co.ToggleFeatures.DisableIncrementals)
|
|
assert.True(t, co.ToggleFeatures.ForceItemDataDownload)
|
|
flagsTD.AssertProviderFlags(t, cmd)
|
|
flagsTD.AssertStorageFlags(t, cmd)
|
|
}
|
|
|
|
func (suite *OneDriveUnitSuite) TestBackupListFlags() {
|
|
t := suite.T()
|
|
|
|
cmd := cliTD.SetUpCmdHasFlags(
|
|
t,
|
|
&cobra.Command{Use: listCommand},
|
|
addOneDriveCommands,
|
|
[]cliTD.UseCobraCommandFn{
|
|
flags.AddAllProviderFlags,
|
|
flags.AddAllStorageFlags,
|
|
},
|
|
flagsTD.WithFlags(
|
|
oneDriveServiceCommand,
|
|
[]string{
|
|
"--" + flags.RunModeFN, flags.RunModeFlagTest,
|
|
"--" + flags.BackupFN, flagsTD.BackupInput,
|
|
},
|
|
flagsTD.PreparedBackupListFlags(),
|
|
flagsTD.PreparedProviderFlags(),
|
|
flagsTD.PreparedStorageFlags()))
|
|
|
|
assert.Equal(t, flagsTD.BackupInput, flags.BackupIDFV)
|
|
flagsTD.AssertBackupListFlags(t, cmd)
|
|
flagsTD.AssertProviderFlags(t, cmd)
|
|
flagsTD.AssertStorageFlags(t, cmd)
|
|
}
|
|
|
|
func (suite *OneDriveUnitSuite) TestBackupDetailsFlags() {
|
|
t := suite.T()
|
|
|
|
cmd := cliTD.SetUpCmdHasFlags(
|
|
t,
|
|
&cobra.Command{Use: detailsCommand},
|
|
addOneDriveCommands,
|
|
[]cliTD.UseCobraCommandFn{
|
|
flags.AddAllProviderFlags,
|
|
flags.AddAllStorageFlags,
|
|
},
|
|
flagsTD.WithFlags(
|
|
oneDriveServiceCommand,
|
|
[]string{
|
|
"--" + flags.RunModeFN, flags.RunModeFlagTest,
|
|
"--" + flags.BackupFN, flagsTD.BackupInput,
|
|
"--" + flags.SkipReduceFN,
|
|
},
|
|
flagsTD.PreparedProviderFlags(),
|
|
flagsTD.PreparedStorageFlags()))
|
|
|
|
co := utils.Control()
|
|
|
|
assert.True(t, co.SkipReduce)
|
|
assert.Equal(t, flagsTD.BackupInput, flags.BackupIDFV)
|
|
flagsTD.AssertProviderFlags(t, cmd)
|
|
flagsTD.AssertStorageFlags(t, cmd)
|
|
}
|
|
|
|
func (suite *OneDriveUnitSuite) TestBackupDeleteFlags() {
|
|
t := suite.T()
|
|
|
|
cmd := cliTD.SetUpCmdHasFlags(
|
|
t,
|
|
&cobra.Command{Use: deleteCommand},
|
|
addOneDriveCommands,
|
|
[]cliTD.UseCobraCommandFn{
|
|
flags.AddAllProviderFlags,
|
|
flags.AddAllStorageFlags,
|
|
},
|
|
flagsTD.WithFlags(
|
|
oneDriveServiceCommand,
|
|
[]string{
|
|
"--" + flags.RunModeFN, flags.RunModeFlagTest,
|
|
"--" + flags.BackupFN, flagsTD.BackupInput,
|
|
},
|
|
flagsTD.PreparedProviderFlags(),
|
|
flagsTD.PreparedStorageFlags()))
|
|
|
|
assert.Equal(t, flagsTD.BackupInput, flags.BackupIDFV)
|
|
flagsTD.AssertProviderFlags(t, cmd)
|
|
flagsTD.AssertStorageFlags(t, cmd)
|
|
}
|
|
|
|
func (suite *OneDriveUnitSuite) TestValidateOneDriveBackupCreateFlags() {
|
|
table := []struct {
|
|
name string
|
|
user []string
|
|
expect assert.ErrorAssertionFunc
|
|
}{
|
|
{
|
|
name: "no users",
|
|
expect: assert.Error,
|
|
},
|
|
{
|
|
name: "users",
|
|
user: []string{"fnord"},
|
|
expect: assert.NoError,
|
|
},
|
|
}
|
|
for _, test := range table {
|
|
suite.Run(test.name, func() {
|
|
err := validateOneDriveBackupCreateFlags(test.user)
|
|
test.expect(suite.T(), err, clues.ToCore(err))
|
|
})
|
|
}
|
|
}
|
|
|
|
func (suite *OneDriveUnitSuite) TestOneDriveBackupDetailsSelectors() {
|
|
for v := 0; v <= version.Backup; v++ {
|
|
suite.Run(fmt.Sprintf("version%d", v), func() {
|
|
for _, test := range utilsTD.OneDriveOptionDetailLookups {
|
|
suite.Run(test.Name, func() {
|
|
t := suite.T()
|
|
|
|
ctx, flush := tester.NewContext(t)
|
|
defer flush()
|
|
|
|
bg := utilsTD.VersionedBackupGetter{
|
|
Details: dtd.GetDetailsSetForVersion(t, v),
|
|
}
|
|
|
|
output, err := runDetailsOneDriveCmd(
|
|
ctx,
|
|
bg,
|
|
"backup-ID",
|
|
test.Opts(t, v),
|
|
false)
|
|
assert.NoError(t, err, clues.ToCore(err))
|
|
assert.ElementsMatch(t, test.Expected(t, v), output.Entries)
|
|
})
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func (suite *OneDriveUnitSuite) TestOneDriveBackupDetailsSelectorsBadFormats() {
|
|
for _, test := range utilsTD.BadOneDriveOptionsFormats {
|
|
suite.Run(test.Name, func() {
|
|
t := suite.T()
|
|
|
|
ctx, flush := tester.NewContext(t)
|
|
defer flush()
|
|
|
|
output, err := runDetailsOneDriveCmd(
|
|
ctx,
|
|
test.BackupGetter,
|
|
"backup-ID",
|
|
test.Opts(t, version.Backup),
|
|
false)
|
|
assert.Error(t, err, clues.ToCore(err))
|
|
assert.Empty(t, output)
|
|
})
|
|
}
|
|
}
|