Remove sharepointids from delta query $select params (#4748)
<!-- PR description--> We are not making use of `GetSharepointIds()` anymore. It was removed a month back, see [PR](https://github.com/alcionai/corso/pull/4436/files#diff-fc955b9b2e400cdda711ab2b6bf459845369691c5abc3973bbfaa1c83a664688L43). So we don't need to fetch this per item-property from graph during delta queries. This will reduce overall mem usage since we don't need to store references to the sharepoint id map. It can also make delta queries go slightly faster since we are transferring & processing fewer bytes over network. --- #### Does this PR need a docs update or release note? - [ ] ✅ Yes, it's included - [ ] 🕐 Yes, but in a later PR - [x] ⛔ No #### Type of change <!--- Please check the type of change your PR introduces: ---> - [ ] 🌻 Feature - [ ] 🐛 Bugfix - [ ] 🗺️ Documentation - [ ] 🤖 Supportability/Tests - [ ] 💻 CI/Deployment - [x] 🧹 Tech Debt/Cleanup #### Issue(s) <!-- Can reference multiple issues. Use one of the following "magic words" - "closes, fixes" to auto-close the Github issue. --> * #<issue> #### Test Plan <!-- How will this be tested prior to merging.--> - [x] 💪 Manual - [x] ⚡ Unit test - [ ] 💚 E2E
This commit is contained in:
parent
6e572fd133
commit
2cd73e2d91
@ -117,7 +117,6 @@ func DefaultDriveItemProps() []string {
|
||||
"package",
|
||||
"parentReference",
|
||||
"root",
|
||||
"sharepointIds",
|
||||
"size",
|
||||
"deleted",
|
||||
"malware",
|
||||
|
||||
@ -273,7 +273,6 @@ func (suite *DrivePagerIntgSuite) TestDriveDeltaPagerQueryParams() {
|
||||
"package",
|
||||
"parentReference",
|
||||
"root",
|
||||
"sharepointIds",
|
||||
"size",
|
||||
"deleted",
|
||||
"malware",
|
||||
|
||||
Loading…
x
Reference in New Issue
Block a user