larryh/corso
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove a few more failing points

Browse Source
This commit is contained in:
Abhishek Pandey 2023-07-21 00:27:26 -07:00
parent d64b8844a5
commit 748ff803d1
1 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/internal/operations/backup.go
View File

@ -235,24 +235,24 @@ func (op *BackupOperation) Run(ctx context.Context) (err error) {
// -----
err = op.persistResults(startTime, &opStats)
if err != nil {
if err != nil && (deets == nil || deets.Empty()) {
op.Errors.Fail(clues.Wrap(err, "persisting backup results"))
return op.Errors.Failure()
}
// force exit without backup in certain cases.
// see: https://github.com/alcionai/corso/pull/2510#discussion_r1113532530
for _, e := range op.Errors.Recovered() {
if clues.HasLabel(e, fault.LabelForceNoBackupCreation) {
logger.Ctx(ctx).
With("error", e).
With(clues.InErr(err).Slice()...).
Infow("completed backup; conditional error forcing exit without model persistence",
"results", op.Results)
// for _, e := range op.Errors.Recovered() {
// if clues.HasLabel(e, fault.LabelForceNoBackupCreation) {
// logger.Ctx(ctx).
// With("error", e).
// With(clues.InErr(err).Slice()...).
// Infow("completed backup; conditional error forcing exit without model persistence",
// "results", op.Results)
return op.Errors.Fail(clues.Wrap(e, "forced backup")).Failure()
}
}
// return op.Errors.Fail(clues.Wrap(e, "forced backup")).Failure()
// }
// }
err = op.createBackupModels(
ctx,