larryh/corso
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Improve tests

Browse Source
This commit is contained in:
Abhishek Pandey 2023-08-21 11:30:28 +05:30
parent 0ec493e7d8
commit 9324fa113d
1 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/internal/m365/collection/drive/url_cache_test.go
View File

@ -87,6 +87,7 @@ func (suite *URLCacheIntegrationSuite) TestURLCacheBasic() {
newItem(newFolderName, true), newItem(newFolderName, true),
control.Copy) control.Copy)
require.NoError(t, err, clues.ToCore(err)) require.NoError(t, err, clues.ToCore(err))
require.NotNil(t, newFolder.GetId()) require.NotNil(t, newFolder.GetId())
nfid := ptr.Val(newFolder.GetId()) nfid := ptr.Val(newFolder.GetId())
@ -131,10 +132,7 @@ func (suite *URLCacheIntegrationSuite) TestURLCacheBasic() {
nfid, nfid,
newItem(newItemName, false), newItem(newItemName, false),
control.Copy) control.Copy)
if err != nil { require.NoError(t, err, clues.ToCore(err))
// Something bad happened, skip this item
continue
}
items = append(items, item) items = append(items, item)
} }
@ -176,13 +174,18 @@ func (suite *URLCacheIntegrationSuite) TestURLCacheBasic() {
nil, nil,
nil) nil)
require.NoError(t, err, clues.ToCore(err)) require.NoError(t, err, clues.ToCore(err))
require.NotNil(t, resp)
require.NotNil(t, resp.Body)
require.Equal(t, http.StatusOK, resp.StatusCode) require.Equal(t, http.StatusOK, resp.StatusCode)
resp.Body.Close()
}(i) }(i)
} }
wg.Wait() wg.Wait()
// Validate that <= 1 delta queries were made by url cache // Validate that exactly 1 delta query was made by url cache
require.LessOrEqual(t, uc.deltaQueryCount, 1) require.Equal(t, 1, uc.deltaQueryCount)
} }
type URLCacheUnitSuite struct { type URLCacheUnitSuite struct {