Don't retry if an item was not found (#2233)
## Description When fetching item data, don't backoff and retry if Graph reported the item was not found. In this case, we mark it as succeeded as we can never get the data anyway. ## Does this PR need a docs update or release note? - [ ] ✅ Yes, it's included - [ ] 🕐 Yes, but in a later PR - [x] ⛔ No ## Type of change - [ ] 🌻 Feature - [x] 🐛 Bugfix - [ ] 🗺️ Documentation - [ ] 🤖 Test - [ ] 💻 CI/Deployment - [x] 🧹 Tech Debt/Cleanup ## Issue(s) * closes #2217 ## Test Plan - [x] 💪 Manual - [ ] ⚡ Unit test - [ ] 💚 E2E
This commit is contained in:
parent
66d17c5fd5
commit
b6a7095c7f
@ -257,6 +257,24 @@ func (col *Collection) streamItems(ctx context.Context) {
|
||||
break
|
||||
}
|
||||
|
||||
// If the data is no longer available just return here and chalk it up
|
||||
// as a success. There's no reason to retry and no way we can backup up
|
||||
// enough information to restore the item anyway.
|
||||
if e := graph.IsErrDeletedInFlight(err); e != nil {
|
||||
atomic.AddInt64(&success, 1)
|
||||
logger.Ctx(ctx).Infow(
|
||||
"Graph reported item not found",
|
||||
"error",
|
||||
e,
|
||||
"service",
|
||||
path.ExchangeService.String(),
|
||||
"category",
|
||||
col.category.String,
|
||||
)
|
||||
|
||||
return
|
||||
}
|
||||
|
||||
if i < numberOfRetries {
|
||||
time.Sleep(time.Duration(3*(i+1)) * time.Second)
|
||||
}
|
||||
@ -270,6 +288,16 @@ func (col *Collection) streamItems(ctx context.Context) {
|
||||
// attempted items.
|
||||
if e := graph.IsErrDeletedInFlight(err); e != nil {
|
||||
atomic.AddInt64(&success, 1)
|
||||
logger.Ctx(ctx).Infow(
|
||||
"Graph reported item not found",
|
||||
"error",
|
||||
e,
|
||||
"service",
|
||||
path.ExchangeService.String(),
|
||||
"category",
|
||||
col.category.String,
|
||||
)
|
||||
|
||||
return
|
||||
}
|
||||
|
||||
|
||||
Loading…
x
Reference in New Issue
Block a user