Fix Gulp not exiting with Ctrl-C and annoying browsersync warning (#751)

## Description

(1) Fix Gupl not exiting with Ctrl-C and (2) annoying browsersync warning
- (1) make sure `gulp` is not PID 1 in container. Add `--init` option
- (2) set `open: false`

Please check the type of change your PR introduces:
- [ ] 🌻 Feature
- [x] 🐛 Bugfix
- [ ] 🗺️ Documentation
- [ ] 🤖 Test
- [ ] 🐹 Trivial/Minor

## Issue(s)

## Test Plan

<!-- How will this be tested prior to merging.-->

- [x] 💪 Manual
- [ ]  Unit test
- [ ] 💚 E2E
This commit is contained in:
Georgi Matev 2022-09-02 18:59:37 -04:00 committed by GitHub
parent 8947164318
commit b6c7488c01
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 4 deletions

View File

@ -4,15 +4,15 @@ buildimage:
docker build -t "corso/website:latest" . docker build -t "corso/website:latest" .
dev: dev:
docker run --rm -it -p 3000:3000 \ docker run --rm -it --init -p 3000:3000 -p 3001:3001 \
-v ${PWD}:/usr/src/website corso/website gulp -v ${PWD}:/usr/src/website corso/website gulp
shell: shell:
docker run --rm -it -p 3000:3000 \ docker run --rm -it -p 3000:3000 -p 3001:3001 \
-v ${PWD}:/usr/src/website corso/website /bin/bash -v ${PWD}:/usr/src/website corso/website /bin/bash
build: build:
docker run --rm -it \ docker run --rm -it --init \
-v ${PWD}:/usr/src/website corso/website gulp build -v ${PWD}:/usr/src/website corso/website gulp build
publish: build publish: build

View File

@ -90,6 +90,7 @@ gulp.task('browsersync', function (callback) {
server: { server: {
baseDir: [paths.dist.base.dir, paths.src.base.dir, paths.base.base.dir] baseDir: [paths.dist.base.dir, paths.src.base.dir, paths.base.base.dir]
}, },
open: false,
}); });
callback(); callback();
}); });