Since scopes are service specific, we cannot
easily house them within the graph QueryParam
struct, unless we bloat the struct with all types.
Alternatively, we could add a generic "scope"
with parsers, much like the Selector itself. But
really, the most simple solution is to only pass
the scope within the tree of service funcs that
use it.
## Description
Creates test package for SharePoint List Collection. Verifies Item and ListInfo for collection
<!-- Insert PR description-->
## Type of change
- [x] 🌻 Feature
## Issue(s)
<!-- Can reference multiple issues. Use one of the following "magic words" - "closes, fixes" to auto-close the Github issue. -->
* related to #1474<issue>
## Test Plan
- [x] ⚡ Unit testt: E2E
## Description
Set secondary user env variables to integration test in CI.
## Type of change
<!--- Please check the type of change your PR introduces: --->
- [ ] 🌻 Feature
- [ ] 🐛 Bugfix
- [ ] 🗺️ Documentation
- [ ] 🤖 Test
- [x] 💻 CI/Deployment
- [ ] 🐹 Trivial/Minor
## Issue(s)
<!-- Can reference multiple issues. Use one of the following "magic words" - "closes, fixes" to auto-close the Github issue. -->
* #<issue>
## Test Plan
<!-- How will this be tested prior to merging.-->
- [ ] 💪 Manual
- [ ] ⚡ Unit test
- [ ] 💚 E2E
## Description
The `#` symbol not at the beginning is technically not valid and fails in podman.
ref: https://docs.docker.com/engine/reference/builder/#format
## Type of change
<!--- Please check the type of change your PR introduces: --->
- [ ] 🌻 Feature
- [ ] 🐛 Bugfix
- [ ] 🗺️ Documentation
- [ ] 🤖 Test
- [x] 💻 CI/Deployment
- [x] 🐹 Trivial/Minor
## Issue(s)
<!-- Can reference multiple issues. Use one of the following "magic words" - "closes, fixes" to auto-close the Github issue. -->
* #<issue>
## Test Plan
<!-- How will this be tested prior to merging.-->
- [x] 💪 Manual
- [ ] ⚡ Unit test
- [ ] 💚 E2E
## Description
Adds the boilerplate for sharepoint selectors
to the selectors package. Many categories are
given filler names (folders, items) and are
expected to change through development as we
pin down the design for those structures.
## Type of change
- [x] 🌻 Feature
## Issue(s)
* #1462
## Test Plan
- [x] ⚡ Unit test
## Description
Allows users to specify whether they want to
select folders by prefix or search behavior.
Search/contains behavior is the default case,
with prefix being an optional deviation if the
folder input is prepended with a '/' character.
Also, propagates the PrefixMatch setting to
all integration tests that rely on selecting only
the default folder in exchange.
## Type of change
- [x] 🌻 Feature
## Issue(s)
* #1224
## Test Plan
- [x] 💪 Manual
- [x] ⚡ Unit test
- [x] 💚 E2E
## Description
For folder-level scopes (ie, scopes that compare
folder-hierarchy path segments), this change
replaces the standard "equals" and "prefix"
string comparators with the new PathContains
and PathPrefix comparators.
Next change is to interpret user inputs in the
cli to determine whether the comparator should
use contains or prefix behavior.
## Type of change
- [x] 🌻 Feature
## Issue(s)
* #1224
## Test Plan
- [x] ⚡ Unit test
- [x] 💚 E2E
Bumps [github.com/tidwall/pretty](https://github.com/tidwall/pretty) from 1.2.0 to 1.2.1.
<details>
<summary>Commits</summary>
<ul>
<li><a href="9090695766"><code>9090695</code></a> Update terminal colors</li>
<li><a href="c563d2cd77"><code>c563d2c</code></a> Update README.md</li>
<li>See full diff in <a href="https://github.com/tidwall/pretty/compare/v1.2.0...v1.2.1">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.107 to 1.44.132.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/aws/aws-sdk-go/releases">github.com/aws/aws-sdk-go's releases</a>.</em></p>
<blockquote>
<h1>Release v1.44.132 (2022-11-07)</h1>
<h3>Service Client Updates</h3>
<ul>
<li><code>service/athena</code>: Updates service API and documentation
<ul>
<li>Adds support for using Query Result Reuse</li>
</ul>
</li>
<li><code>service/autoscaling</code>: Updates service API and documentation
<ul>
<li>This release adds support for two new attributes for attribute-based instance type selection - NetworkBandwidthGbps and AllowedInstanceTypes.</li>
</ul>
</li>
<li><code>service/cloudtrail</code>: Updates service API and documentation
<ul>
<li>This release includes support for configuring a delegated administrator to manage an AWS Organizations organization CloudTrail trails and event data stores, and AWS Key Management Service encryption of CloudTrail Lake event data stores.</li>
</ul>
</li>
<li><code>service/ec2</code>: Updates service API and documentation
<ul>
<li>This release adds support for two new attributes for attribute-based instance type selection - NetworkBandwidthGbps and AllowedInstanceTypes.</li>
</ul>
</li>
<li><code>service/elasticache</code>: Updates service API and documentation
<ul>
<li>Added support for IPv6 and dual stack for Memcached and Redis clusters. Customers can now launch new Redis and Memcached clusters with IPv6 and dual stack networking support.</li>
</ul>
</li>
<li><code>service/mediaconvert</code>: Updates service API and documentation
<ul>
<li>The AWS Elemental MediaConvert SDK has added support for setting the SDR reference white point for HDR conversions and conversion of HDR10 to DolbyVision without mastering metadata.</li>
</ul>
</li>
<li><code>service/models.lex.v2</code>: Updates service API, documentation, and paginators</li>
<li><code>service/ssm</code>: Updates service API and documentation
<ul>
<li>This release includes support for applying a CloudWatch alarm to multi account multi region Systems Manager Automation</li>
</ul>
</li>
<li><code>service/wafv2</code>: Updates service documentation</li>
<li><code>service/wellarchitected</code>: Updates service API, documentation, and paginators</li>
<li><code>service/workspaces</code>: Updates service API and documentation
<ul>
<li>This release adds protocols attribute to workspaces properties data type. This enables customers to migrate workspaces from PC over IP (PCoIP) to WorkSpaces Streaming Protocol (WSP) using create and modify workspaces public APIs.</li>
</ul>
</li>
</ul>
<h1>Release v1.44.131 (2022-11-04)</h1>
<h3>Service Client Updates</h3>
<ul>
<li><code>service/ec2</code>: Updates service API and documentation
<ul>
<li>This release adds API support for the recipient of an AMI account share to remove shared AMI launch permissions.</li>
</ul>
</li>
<li><code>service/emr-containers</code>: Updates service API, documentation, and paginators</li>
<li><code>service/logs</code>: Updates service documentation
<ul>
<li>Doc-only update for bug fixes and support of export to buckets encrypted with SSE-KMS</li>
</ul>
</li>
</ul>
<h1>Release v1.44.130 (2022-11-03)</h1>
<h3>Service Client Updates</h3>
<ul>
<li><code>service/memorydb</code>: Updates service API and documentation</li>
<li><code>service/sagemaker</code>: Updates service API
<ul>
<li>Amazon SageMaker now supports running training jobs on ml.trn1 instance types.</li>
</ul>
</li>
</ul>
<h1>Release v1.44.129 (2022-11-02)</h1>
<h3>Service Client Updates</h3>
<ul>
<li><code>service/iotsitewise</code>: Updates service API, documentation, and paginators</li>
<li><code>service/s3control</code>: Updates service API and documentation
<ul>
<li>S3 on Outposts launches support for Lifecycle configuration for Outposts buckets. With S3 Lifecycle configuration, you can mange objects so they are stored cost effectively. You can manage objects using size-based rules and specify how many noncurrent versions bucket will retain.</li>
</ul>
</li>
<li><code>service/sagemaker</code>: Updates service API and documentation</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="ddc6ad3b4d"><code>ddc6ad3</code></a> Release v1.44.132 (2022-11-07) (<a href="https://github-redirect.dependabot.com/aws/aws-sdk-go/issues/4615">#4615</a>)</li>
<li><a href="ab32314d13"><code>ab32314</code></a> Release v1.44.131 (2022-11-04) (<a href="https://github-redirect.dependabot.com/aws/aws-sdk-go/issues/4614">#4614</a>)</li>
<li><a href="0a557e1761"><code>0a557e1</code></a> upgrades version of golang.org/x/net (<a href="https://github-redirect.dependabot.com/aws/aws-sdk-go/issues/4613">#4613</a>)</li>
<li><a href="a5cf45f28a"><code>a5cf45f</code></a> Release v1.44.130 (2022-11-03) (<a href="https://github-redirect.dependabot.com/aws/aws-sdk-go/issues/4611">#4611</a>)</li>
<li><a href="aeeca02c4a"><code>aeeca02</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/aws/aws-sdk-go/issues/4608">#4608</a> from sbiscigl/fix-codegen-accountid</li>
<li><a href="13e3d772f7"><code>13e3d77</code></a> Release v1.44.129 (2022-11-02) (<a href="https://github-redirect.dependabot.com/aws/aws-sdk-go/issues/4609">#4609</a>)</li>
<li><a href="fbad6e2326"><code>fbad6e2</code></a> Fixes codegen for multiple account ids</li>
<li><a href="4f57f90dd0"><code>4f57f90</code></a> Release v1.44.128 (2022-11-01) (<a href="https://github-redirect.dependabot.com/aws/aws-sdk-go/issues/4605">#4605</a>)</li>
<li><a href="9bfd7378b1"><code>9bfd737</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/aws/aws-sdk-go/issues/4592">#4592</a> from skmcgrail/infinity</li>
<li><a href="3896c7a34d"><code>3896c7a</code></a> Release v1.44.127 (2022-10-31) (<a href="https://github-redirect.dependabot.com/aws/aws-sdk-go/issues/4604">#4604</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/aws/aws-sdk-go/compare/v1.44.107...v1.44.132">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
You can trigger a rebase of this PR by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Bumps [golang.org/x/tools](https://github.com/golang/tools) from 0.1.12 to 0.2.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/golang/tools/releases">golang.org/x/tools's releases</a>.</em></p>
<blockquote>
<h2>gopls/v0.2.0</h2>
<ul>
<li>Many improvements to autocompletion. In particular, support for completions of array, slice, map, and function literals (<a href="https://github.com/muirdm"><code>@muirdm</code></a>).</li>
<li>A new diff algorithm (<a href="https://github.com/sergi/go-diff">github.com/sergi/go-diff</a>) that improves handling of line endings on different operating systems (<a href="https://github.com/ianthehat"><code>@ianthehat</code></a>).</li>
<li>Improved caching and memory usage (<a href="https://github.com/stamblerre"><code>@stamblerre</code></a>).</li>
<li>Command-line support for links, suggested fixes, and imports (<a href="https://github.com/kalmanb"><code>@kalmanb</code></a>).</li>
<li>Command-line support for references, signature, and symbols (<a href="https://github.com/rentziass"><code>@rentziass</code></a>).</li>
<li>Command-line support for rename (<a href="https://github.com/hartzell"><code>@hartzell</code></a>).</li>
</ul>
<h3>Opt-in:</h3>
<ul>
<li>Get diagnostics from <a href="https://staticcheck.io/">staticcheck</a> by configuring <code>"staticcheck": true</code> in your gopls settings (<a href="https://github.com/ianthehat"><code>@ianthehat</code></a>).</li>
<li>Get autocompletion of unimported packages and symbols by configuring <code>"completeUnimported": true</code> in your gopls settings (<a href="https://github.com/heschik"><code>@heschik</code></a>).</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="f112c43328"><code>f112c43</code></a> go.mod: update golang.org/x dependencies</li>
<li><a href="207f456f2d"><code>207f456</code></a> go/internal/gcimporter: bump version number in skew check</li>
<li><a href="65196caeed"><code>65196ca</code></a> gopls/README.md: fix wording around supported Go versions</li>
<li><a href="61280309af"><code>6128030</code></a> gopls/internal: support renaming packages with int. test variants</li>
<li><a href="649df2ea1a"><code>649df2e</code></a> go.mod: mark as requiring -compat 1.16</li>
<li><a href="91311ab3b8"><code>91311ab</code></a> gopls/internal/lsp/cache: better import path hygiene</li>
<li><a href="9eda97bc2d"><code>9eda97b</code></a> go/analysis: enable a test that applies after go list behavior change</li>
<li><a href="b50d7ba6ee"><code>b50d7ba</code></a> gopls: minor cleanup of standalone package support</li>
<li><a href="502b93c33e"><code>502b93c</code></a> gopls/internal/lsp: tolerate missing end position in RelatedInformation</li>
<li><a href="d67c3ada09"><code>d67c3ad</code></a> internal/imports: repair warnings from default analyzers</li>
<li>Additional commits viewable in <a href="https://github.com/golang/tools/compare/v0.1.12...v0.2.0">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
## Description
<!-- Insert PR description-->
## Type of change
<!--- Please check the type of change your PR introduces: --->
- [ ] 🌻 Feature
- [ ] 🐛 Bugfix
- [ ] 🗺️ Documentation
- [ ] 🤖 Test
- [x] 💻 CI/Deployment
- [ ] 🐹 Trivial/Minor
## Test Plan
<!-- How will this be tested prior to merging.-->
- [x] 💪 Manual
- [ ] ⚡ Unit test
- [ ] 💚 E2E
## Description
Creates Sharepoint Info within the details package. SharepointInfo constructor and test package included
<!-- Insert PR description-->
## Type of change
<!--- Please check the type of change your PR introduces: --->
- [x] 🌻 Feature
## Test Plan
- [x] ⚡ Unit test
## Description
Add EndTime to Exchange events. Also fixes a testcase around start time.
## Type of change
<!--- Please check the type of change your PR introduces: --->
- [x] 🌻 Feature
- [ ] 🐛 Bugfix
- [ ] 🗺️ Documentation
- [ ] 🤖 Test
- [ ] 💻 CI/Deployment
- [ ] 🐹 Trivial/Minor
## Issue(s)
<!-- Can reference multiple issues. Use one of the following "magic words" - "closes, fixes" to auto-close the Github issue. -->
* https://github.com/alcionai/corso/issues/1366
## Test Plan
<!-- How will this be tested prior to merging.-->
- [ ] 💪 Manual
- [x] ⚡ Unit test
- [ ] 💚 E2E
## Description
Adds Corso CLI demo to website. Includes instructions on how to use Terminalizer to generate the demo.
Can and should investigate a better maintained project in the future.
## Type of change
<!--- Please check the type of change your PR introduces: --->
- [x] 🌻 Feature
- [ ] 🐛 Bugfix
- [ ] 🗺️ Documentation
- [ ] 🤖 Test
- [ ] 💻 CI/Deployment
- [ ] 🐹 Trivial/Minor
## Issue(s)
## Test Plan
<!-- How will this be tested prior to merging.-->
- [x] 💪 Manual
- [ ] ⚡ Unit test
- [ ] 💚 E2E
## Description
Three primary changes:
1. move the list of load test users into a secret in the github test domain.
2. purge all data that was generated for users in the load test
3. fix all `m356` typos.
## Type of change
- [x] 🤖 Test
- [x] 💻 CI/Deployment
## Issue(s)
* #1266
## Test Plan
- [x] 💪 Manual
- [x] 💚 E2E
## Description
Configure a sitemap for search engine indexing
## Type of change
<!--- Please check the type of change your PR introduces: --->
- [x] 🗺️ Documentation
## Test Plan
- [x] 💪 Manual
## Description
`make clean` will now be executed before a Docker image is built. While it technically has no impact on the Docker image, it will ensure that there are no stale Node modules lying around when a build is executed after the creation of a new image.
While running a Docker build without a cache is an additional option, it does not prevent stale local node_modules directories and suffers from the overhead of having to pull down a large Ubuntu base image every time.
## Type of change
- [x] 🐛 Bugfix
## Description
Store and retrieve owner info for onedrive files.
## Type of change
<!--- Please check the type of change your PR introduces: --->
- [x] 🌻 Feature
- [ ] 🐛 Bugfix
- [ ] 🗺️ Documentation
- [ ] 🤖 Test
- [ ] 💻 CI/Deployment
- [ ] 🐹 Trivial/Minor
## Issue(s)
<!-- Can reference multiple issues. Use one of the following "magic words" - "closes, fixes" to auto-close the Github issue. -->
* https://github.com/alcionai/corso/issues/1366
## Test Plan
<!-- How will this be tested prior to merging.-->
- [x] 💪 Manual
- [x] ⚡ Unit test
- [x] 💚 E2E
## Description
Adds two specialized filters: path prefix and path
contains. These filters differ from prior additions
in two ways: 1/ they accept a slice of inputs and
perform an implicit any-match when compared,
2/ they have particular rules about matching
completely within delimited elements.
In the next PR, these filters will replace the
standard prefix and contains comparisons that
are currently used in folder selection.
## Type of change
- [x] 🌻 Feature
## Issue(s)
* #1224
## Test Plan
- [x] 💚 E2E
## Description
* fix reference to `corso-maintainers` for dependabot reviewers
## Type of change
<!--- Please check the type of change your PR introduces: --->
- [ ] 🌻 Feature
- [ ] 🐛 Bugfix
- [ ] 🗺️ Documentation
- [ ] 🤖 Test
- [X] 💻 CI/Deployment
- [ ] 🐹 Trivial/Minor
## Test Plan
<!-- How will this be tested prior to merging.-->
- [X] 💪 Manual
- [ ] ⚡ Unit test
- [ ] 💚 E2E
## Description
We need cli docs to be available to be able to be able to build docs.
## Type of change
<!--- Please check the type of change your PR introduces: --->
- [ ] 🌻 Feature
- [ ] 🐛 Bugfix
- [ ] 🗺️ Documentation
- [ ] 🤖 Test
- [x] 💻 CI/Deployment
- [ ] 🐹 Trivial/Minor
## Issue(s)
<!-- Can reference multiple issues. Use one of the following "magic words" - "closes, fixes" to auto-close the Github issue. -->
* https://github.com/alcionai/corso/pull/1434
## Test Plan
<!-- How will this be tested prior to merging.-->
- [x] 💪 Manual
- [ ] ⚡ Unit test
- [ ] 💚 E2E
## Description
We can probably remove the requirement on `Publish-Docs` as we have move the check to `Docs-Linting`. Having this check in `Publish-Docs` does not run for docs only change as the previous steps(Test-Suite) are skipped and as a result this gets skipped.
## Type of change
<!--- Please check the type of change your PR introduces: --->
- [ ] 🌻 Feature
- [ ] 🐛 Bugfix
- [ ] 🗺️ Documentation
- [ ] 🤖 Test
- [x] 💻 CI/Deployment
- [ ] 🐹 Trivial/Minor
## Issue(s)
<!-- Can reference multiple issues. Use one of the following "magic words" - "closes, fixes" to auto-close the Github issue. -->
* #<issue>
## Test Plan
<!-- How will this be tested prior to merging.-->
- [x] 💪 Manual
- [ ] ⚡ Unit test
- [ ] 💚 E2E
## Description
Introduces config options (`--disable-tls` and `--disable-tls-verification`) to turn off TLS and TLS verification
## Type of change
<!--- Please check the type of change your PR introduces: --->
- [x] 🌻 Feature
- [ ] 🐛 Bugfix
- [ ] 🗺️ Documentation
- [ ] 🤖 Test
- [ ] 💻 CI/Deployment
- [ ] 🐹 Trivial/Minor
## Issue(s)
<!-- Can reference multiple issues. Use one of the following "magic words" - "closes, fixes" to auto-close the Github issue. -->
* #1415
## Test Plan
<!-- How will this be tested prior to merging.-->
- [ ] 💪 Manual
- [x] ⚡ Unit test
- [ ] 💚 E2E
## Description
As the exchange container resolvers are pretty close implementation-wise, consolidate the generic code. Also move some of the tests around to better fit what file has the code being tested
## Type of change
<!--- Please check the type of change your PR introduces: --->
- [x] 🌻 Feature
- [ ] 🐛 Bugfix
- [ ] 🗺️ Documentation
- [ ] 🤖 Test
- [ ] 💻 CI/Deployment
- [ ] 🐹 Trivial/Minor
## Issue(s)
* closes#1362
## Test Plan
<!-- How will this be tested prior to merging.-->
- [ ] 💪 Manual
- [x] ⚡ Unit test
- [ ] 💚 E2E
