711 Commits

Author SHA1 Message Date
Niraj Tolia
d7ec159b08
Don't include an empty architecture document (#1274)
## Description

Removes a blank document.

## Type of change

- [x] 🗺️ Documentation
v0.0.0-alpha3
2022-10-21 01:06:43 +00:00
Keepers
286a74e819
persist service tag in backup model, list by service (#1233)
## Description

Adds a tag describing the service within the backup model and the backup details model.  Adds a filter builder pattern to the store wrapper for filtering results according to certain tags.  Finally, adds a filter builder to specify the service type when listing backups.

## Type of change

- [x] 🐛 Bugfix

## Issue(s)

* #1226

## Test Plan

- [x] 💪 Manual
- [x]  Unit test
2022-10-21 01:04:54 +00:00
Niraj Tolia
e82cdadc62
Add section on how to get Corso (#1270)
## Description

Add instructions on where to get Corso binaries

## Type of change

- [x] 🗺️ Documentation
2022-10-21 00:38:31 +00:00
Niraj Tolia
093d2b9639
Edit M365 access docs (#1256)
## Description

- Use subsections for easier linking
- Consolidate some text
- Switch to MD images as I needed to zoom in on every one in its default config
- Switch to MD images for alignment with rest of the page
- Add alt-text to images
- Ensure consistency for order of Azure variables
- Add missing links
- Add missing instructions

## Type of change

- [x] 🐛 Bugfix
- [x] 🗺️ Documentation
2022-10-21 00:09:31 +00:00
Niraj Tolia
d877240d4f
Clean up Repository information (#1267)
## Description

- Remove bucket creationn from the quickstart
- Remove repo connect from the quickstart
- Add examples to the repo page
- Reoder setup pages given pre-requisites to the examples on the repo page
- Cleanups, edits, and clarifications on the repo page

## Type of change

<!--- Please check the type of change your PR introduces: --->
- [x] 🌻 Feature
- [x] 🐛 Bugfix
- [x] 🗺️ Documentation

## Issue(s)

<!-- Can reference multiple issues. Use one of the following "magic words" - "closes, fixes" to auto-close the Github issue. -->
* Closes #1262
2022-10-20 23:02:15 +00:00
Niraj Tolia
268e12d14f
Edit Quickstart backup and restore sections (#1263)
## Description

- Adds command tabs for back and restore
- Reorder Exchange CLI restore page
- Minor consistency tweaks
- Fix subsection headers
- Fix restore command
- Address TODO in repos page

## Type of change

- [x] 🗺️ Documentation
2022-10-20 22:59:01 +00:00
Abin Simon
1cad17bfc7
Use filepath instead of path (#1247)
## Description

`path` is not cross platform as it hardcodes / as the separator. Also add a lint rule for this.

## Type of change

<!--- Please check the type of change your PR introduces: --->
- [ ] 🌻 Feature
- [ ] 🐛 Bugfix
- [ ] 🗺️ Documentation
- [ ] 🤖 Test
- [ ] 💻 CI/Deployment
- [ ] 🐹 Trivial/Minor

## Issue(s)

<!-- Can reference multiple issues. Use one of the following "magic words" - "closes, fixes" to auto-close the Github issue. -->
* fixes https://github.com/alcionai/corso/issues/1236

## Test Plan

<!-- How will this be tested prior to merging.-->
- [ ] 💪 Manual
- [ ]  Unit test
- [ ] 💚 E2E
2022-10-20 22:57:30 +00:00
Niraj Tolia
8906fbea17
Clean up the quickstart page (#1254)
- Consistency across commands
- Consistency across subsection titles
- Reduce number of tabs
- Clarifications in the text
- Add tabs to creating your first backup

Co-authored-by: Georgi Matev <gmatev@alcion.ai>
2022-10-20 13:50:44 -07:00
Abin Simon
7221d616ac
Add CORSO_VERSION to docs env when building (#1215)
## Description

Adds the new CORSO_VERSION env needed to build docs in CI.

![2022-10-19-16-02-13](https://user-images.githubusercontent.com/14259816/196668301-cb5ad90c-4735-4132-b3ea-764d30948a62.png)

## Type of change

<!--- Please check the type of change your PR introduces: --->
- [ ] 🌻 Feature
- [ ] 🐛 Bugfix
- [x] 🗺️ Documentation
- [ ] 🤖 Test
- [x] 💻 CI/Deployment
- [ ] 🐹 Trivial/Minor

## Issue(s)

<!-- Can reference multiple issues. Use one of the following "magic words" - "closes, fixes" to auto-close the Github issue. -->
* fixes https://github.com/alcionai/corso/issues/29
* https://github.com/alcionai/corso/pull/1205

## Test Plan

<!-- How will this be tested prior to merging.-->
- [x] 💪 Manual
- [ ]  Unit test
- [ ] 💚 E2E
2022-10-20 20:48:30 +00:00
Abin Simon
f0e28ea4c7
Use .exe when building for Windows (#1251)
## Description

Use .exe when building for Windows. Adds quoting for paths.

## Type of change

<!--- Please check the type of change your PR introduces: --->
- [ ] 🌻 Feature
- [ ] 🐛 Bugfix
- [ ] 🗺️ Documentation
- [ ] 🤖 Test
- [x] 💻 CI/Deployment
- [x] 🐹 Trivial/Minor

## Issue(s)

<!-- Can reference multiple issues. Use one of the following "magic words" - "closes, fixes" to auto-close the Github issue. -->
* #<issue>

## Test Plan

<!-- How will this be tested prior to merging.-->
- [x] 💪 Manual
- [ ]  Unit test
- [ ] 💚 E2E
2022-10-20 18:45:37 +00:00
Vaibhav Kamra
7919d5a321
Fix build script for Mac M1 (#1257)
## Description

`uname -m` will be `arm64` not `arm`

## Type of change

<!--- Please check the type of change your PR introduces: --->
- [ ] 🌻 Feature
- [ ] 🐛 Bugfix
- [ ] 🗺️ Documentation
- [ ] 🤖 Test
- [ ] 💻 CI/Deployment
- [x] 🐹 Trivial/Minor

## Test Plan

<!-- How will this be tested prior to merging.-->
- [x] 💪 Manual
- [ ]  Unit test
- [ ] 💚 E2E
2022-10-20 18:44:51 +00:00
Danny
63e1cec71c
GC: Remove DeadCode (#1253)
## Description
Code removal from GraphConnector
`AddItemsToCollection` removed from graph_connector.go
## Type of change

- [x] 🐹 Trivial/Minor

## Issue(s)

<!-- Can reference multiple issues. Use one of the following "magic words" - "closes, fixes" to auto-close the Github issue. -->
* #<issue>

## Test Plan

<!-- How will this be tested prior to merging.-->
- [ ] 💪 Manual
- [x]  Unit test
- [ ] 💚 E2E
2022-10-20 17:54:36 +00:00
Niraj Tolia
0214db9b13
Remove MPU S3 perms from docs (#1221)
## Description

Remove MPU S3 perms from docs as Kopia should not need S3
multi-part-upload permissions

## Type of change

- [x] 🐛 Bugfix
- [x] 🗺️ Documentation

## Test Plan

- [x] 💪 Manual
2022-10-20 17:27:18 +00:00
Niraj Tolia
f78e3ff5bd
Start filling out the quick start section (#1248)
## Description

This commit also fixes a couple of other doc "bugs" and creates tab consistency.

## Type of change

- [x] 🌻 Feature
- [x] 🐛 Bugfix
- [x] 🗺️ Documentation
2022-10-20 16:59:49 +00:00
Keepers
f57b0f1f7e
add contact generation to the factory script (#1202)
## Type of change

- [x] 🤖 Test

## Issue(s)

* #902

## Test Plan

- [x] 💪 Manual
- [x] 💚 E2E
2022-10-20 16:58:12 +00:00
Abin Simon
e3c16e1793
Rename tutorial to quickstart (#1250)
## Description

There was a missed link to tutorial in main page in https://github.com/alcionai/corso/pull/1245. Fixes that. Also enabled docs build (not push) for docs in CI as that is pretty fast anyways. Fixes `Push-Docs` job failing in `main`.

## Type of change

<!--- Please check the type of change your PR introduces: --->
- [ ] 🌻 Feature
- [ ] 🐛 Bugfix
- [x] 🗺️ Documentation
- [ ] 🤖 Test
- [ ] 💻 CI/Deployment
- [ ] 🐹 Trivial/Minor

## Issue(s)

<!-- Can reference multiple issues. Use one of the following "magic words" - "closes, fixes" to auto-close the Github issue. -->
* #<issue>

## Test Plan

<!-- How will this be tested prior to merging.-->
- [x] 💪 Manual
- [ ]  Unit test
- [x] 💚 E2E
2022-10-20 16:03:07 +00:00
Keepers
d3ea669be4
update test fmt pkg in load_test action (#1220)
## Type of change

- [x] 🐹 Trivial/Minor
2022-10-20 13:47:50 +00:00
Danny
bb7e48a82e
GC: Use of graph.ContainerResolver for directory structure and data retrieval (#1134)
## Description

`graph.ContainerResolver` has the capacity to keep the directory structure of the m365 objects that are helpful within a user's account. Leveraging this abstraction allows for a better flow of data from M365 into storage. 

## Type of change


- [x]  : Optimization

## Issue(s)

* closes #1125<issue>
* closes #1122
## Test Plan


- [x]  Unit test
2022-10-20 12:49:09 +00:00
Niraj Tolia
d30f6963c0
Fix Docker build docs (#1249)
## Description

s/gcr/ghcr

## Type of change

- [x] 🐛 Bugfix
- [x] 🗺️ Documentation
2022-10-20 07:23:27 +00:00
Niraj Tolia
e6ab739dde
Rename Setup sidebar and page titles (#1246)
## Description

This saves us from having to add Corso everywhere and also addresses comments in a previous PR.

## Type of change

- [x] 🗺️ Documentation
2022-10-20 05:15:48 +00:00
Abin Simon
97791a6787
Rename dockercheck to check and check to localcheck (#1244)
## Description

Followup for https://github.com/alcionai/corso/pull/1240

## Type of change

<!--- Please check the type of change your PR introduces: --->
- [ ] 🌻 Feature
- [ ] 🐛 Bugfix
- [x] 🗺️ Documentation
- [ ] 🤖 Test
- [x] 💻 CI/Deployment
- [ ] 🐹 Trivial/Minor

## Issue(s)

<!-- Can reference multiple issues. Use one of the following "magic words" - "closes, fixes" to auto-close the Github issue. -->
* https://github.com/alcionai/corso/pull/1240

## Test Plan

<!-- How will this be tested prior to merging.-->
- [x] 💪 Manual
- [ ]  Unit test
- [ ] 💚 E2E
2022-10-20 05:14:13 +00:00
Niraj Tolia
526f5d542d
Minor help text tweaks (#1238)
## Description

Minor help text tweaks

## Type of change

- [x] 🐛 Bugfix
- [x] 🐹 Trivial/Minor
2022-10-20 04:47:45 +00:00
Niraj Tolia
edb152d9c1
Rename Tutorial to Quickstart (#1245)
## Description

Rename Tutorial to Quickstart

Content rework to follow later

## Type of change

<!--- Please check the type of change your PR introduces: --->
- [x] 🗺️ Documentation
2022-10-20 04:17:34 +00:00
Niraj Tolia
0ee64f7e79
Consolidate setup docs (#1243)
## Description

Consolidate setup docs

Renames the "Initial Configuration" section to "Initial Setup" for better flow and upcoming changes.

## Type of change

- [x] 🗺️ Documentation
2022-10-20 03:54:57 +00:00
Niraj Tolia
d7226a992c
Make sidebar capitalization consistent with MD (#1242)
## Description

Make sidebar capitalization consistent with markdown

## Type of change

- [x] 🐛 Bugfix
- [x] 🗺️ Documentation
2022-10-20 03:24:21 +00:00
Niraj Tolia
fe6ef47c88
Nuke README reference to non-Docker checks (#1240)
## Description

Nuke README reference to non-Docker checks

## Type of change

- [x] 🐹 Trivial/Minor
2022-10-20 03:09:47 +00:00
Georgi Matev
b93e990429
Actually fix the mdgen check (#1241)
## Description

The check if the executing `mdgen` binary works on the current platform was not correct since the initial docker run always returns success.

## Type of change

<!--- Please check the type of change your PR introduces: --->
- [ ] 🌻 Feature
- [x] 🐛 Bugfix
- [ ] 🗺️ Documentation
- [ ] 🤖 Test
- [ ] 💻 CI/Deployment
- [ ] 🐹 Trivial/Minor

## Issue(s)

<!-- Can reference multiple issues. Use one of the following "magic words" - "closes, fixes" to auto-close the Github issue. -->

## Test Plan

<!-- How will this be tested prior to merging.-->
- [x] 💪 Manual
- [ ]  Unit test
- [ ] 💚 E2E
2022-10-20 02:27:20 +00:00
Niraj Tolia
b4e3ea0e05
Simplify docs on how to run Corso (#1239)
## Description

Simplify docs on how to run Corso

- Add Docker and Windows binary instructions
- Add synced tabs
- Tweak tabs content to allow for copy-paste

## Type of change

- [x] 🗺️ Documentation
2022-10-20 02:01:37 +00:00
Keepers
6055d8c16a
adds collection-level progress display (#1187)
## Description

Adds a progress spinner tracking the collection-level work on an incremental basis.  Useful for tracking collection progress when individual files may be too quickly resolved to visibly show progress bars.

In the future, we could combine the two so that the current item in progress always displays below the collection tracker.

## Type of change

- [x] 🌻 Feature

## Issue(s)

* #1112

## Test Plan

- [x] 💪 Manual
- [x]  Unit test
2022-10-20 01:12:47 +00:00
Abin Simon
6846ebf964
Skip mdgen build in case of valid mdgen in Makefile (#1214)
## Description

`_validatemdgen` resulted in the build for mdgen to always happen. This fixes that.

## Type of change

<!--- Please check the type of change your PR introduces: --->
- [ ] 🌻 Feature
- [ ] 🐛 Bugfix
- [x] 🗺️ Documentation
- [ ] 🤖 Test
- [x] 💻 CI/Deployment
- [ ] 🐹 Trivial/Minor

## Issue(s)

<!-- Can reference multiple issues. Use one of the following "magic words" - "closes, fixes" to auto-close the Github issue. -->
* #<issue>

## Test Plan

<!-- How will this be tested prior to merging.-->
- [x] 💪 Manual
- [ ]  Unit test
- [ ] 💚 E2E
2022-10-20 00:19:41 +00:00
ashmrtn
afa8734268
Fix OneDrive details list flag validation (#1232)
## Description

Call the OneDrive flag validation function to ensure flags that take time strings are formatted properly. Also add tests to ensure there's no future regressions for this

First commit has important code changes. Remainder of commits have test data/setup

## Type of change

<!--- Please check the type of change your PR introduces: --->
- [ ] 🌻 Feature
- [x] 🐛 Bugfix
- [ ] 🗺️ Documentation
- [x] 🤖 Test
- [ ] 💻 CI/Deployment
- [ ] 🐹 Trivial/Minor

## Issue(s)

* closes #1231 
* #913 

## Test Plan

<!-- How will this be tested prior to merging.-->
- [ ] 💪 Manual
- [x]  Unit test
- [ ] 💚 E2E
2022-10-19 23:03:31 +00:00
Keepers
d98ba729b8
Issue 902 fails (#1227)
## Notes

All users in the test set have been ensured to have a
complete set of populated data, relevant to the per-
category-per-user assertions in the test.

## Type of change

- [x] 🐛 Bugfix
- [x] 🤖 Test

## Issue(s)

* #902

## Test Plan

- [x] 💪 Manual
- [x] 💚 E2E
2022-10-19 21:58:48 +00:00
Keepers
4cc60be091
add azure_tenant_id envvar --env entry (#1219)
## Type of change

- [x] 🐛 Bugfix

## Issue(s)

* #1211

## Test Plan

- [x] 💪 Manual
2022-10-19 20:43:26 +00:00
Niraj Tolia
fc218457d7
Clean up "install" section (#1213)
## Description

This is the first of many changes to improve the Corso documentation. This page
will see more edits with the possibility of further consolidaiton.

The issues this and subsequent comments are trying to fix include:

- Complexity
- Too many clicks
- Information spread out across too many pages
- No single-page getting started guide
- Incorrect or stale information

## Type of change

<!--- Please check the type of change your PR introduces: --->
- [x] 🗺️ Documentation

## Test Plan

- [x] 💪 Manual
2022-10-19 20:17:48 +00:00
Keepers
2a51cc6975
investigate users not appearing in test assertions (#1188)
## Description

Some minor bugs.  Further assurance that users will appear
in the test results as expected will require manual curation
or addition of data in each user's account.

## Type of change

- [x] 🐛 Bugfix
- [x] 🤖 Test

## Issue(s)

* #902

## Test Plan

- [x] 💪 Manual
- [x] 💚 E2E
2022-10-19 19:39:00 +00:00
ashmrtn
bc316df6d9
Remove flakey test (#1223)
## Description

There's enough other tests in the codebase that check the functionality of getting multiple folders that it should be fine without this one.

## Type of change

<!--- Please check the type of change your PR introduces: --->
- [ ] 🌻 Feature
- [x] 🐛 Bugfix
- [ ] 🗺️ Documentation
- [x] 🤖 Test
- [ ] 💻 CI/Deployment
- [ ] 🐹 Trivial/Minor

## Issue(s)

* closes #1222 

## Test Plan

<!-- How will this be tested prior to merging.-->
- [ ] 💪 Manual
- [x]  Unit test
- [ ] 💚 E2E
2022-10-19 18:31:06 +00:00
Keepers
e57aa124ac
prevent logger flag from overriding --help (#1217)
## Type of change

- [x] 🐛 Bugfix

## Issue(s)

* #763

## Test Plan

- [x] 💪 Manual
2022-10-19 18:02:05 +00:00
ashmrtn
86740f1457
Lint rule for making new contexts in tests (#1199)
## Description
Create a lint rule that warns if `context.TODO` or `context.Background` are called in tests. This helps standardize the use of `tester.NewContext` and ensures log messages are properly flushed during tests.

Output from the linter is similar to (sadly can't get rid of the `\\` in there)
```
pkg/services/m365/m365_test.go:49:22: use of `context.Background` forbidden because "tests should use tester\\.NewContext" (forbidigo) 
        ids, err := UserIDs(context.Background(), acct)
```

## Type of change

<!--- Please check the type of change your PR introduces: --->
- [ ] 🌻 Feature
- [ ] 🐛 Bugfix
- [ ] 🗺️ Documentation
- [ ] 🤖 Test
- [x] 💻 CI/Deployment
- [ ] 🐹 Trivial/Minor

## Issue(s)

* closes #1198 

## Test Plan

<!-- How will this be tested prior to merging.-->
- [x] 💪 Manual
- [ ]  Unit test
- [ ] 💚 E2E
2022-10-19 17:30:28 +00:00
Niraj Tolia
43a3dcbc84
Minor tweak env help text (#1212)
## Description

Minor tweak env help text

## Type of change

- [x] 🗺️ Documentation
- [x] 🐹 Trivial/Minor
2022-10-19 16:31:32 +00:00
Danny
5cd2583466
GC: Purge: Updates to use graph.ContainerResolver (#1190)
## Description
purge.go to use the ContainerResolvers to collect containers from the Graph Connector.

NOTE: CollectFolders in service_query.go unchanged. `CollectFolderrs()` is stubbed for another PR. This will reduce the amount of line changes to be used in the future. 
<!-- Insert PR description-->

## Type of change

- [x] 🐛 Bugfix

## Issue(s)

<!-- Can reference multiple issues. Use one of the following "magic words" - "closes, fixes" to auto-close the Github issue. -->
*closes  #1189<issue>

## Test Plan

- [x]  Unit test
2022-10-19 14:08:03 +00:00
Danny
5ff890b760
GC: Backup: OneDrive: Call Backup on User without OneDrive Access FIX (#1197)
## Description
Corso should be able to have `Backup` called on a user that does not have OneDrive or does not have OneDrive files without producing an error. This feature branch creates OneDriveIntegration testing to be able to fetch OneDrive data for a particular user. 

Logic changed within `drive.go` 

## Type of change

<!--- Please check the type of change your PR introduces: --->
- [x] 🌻 Feature
- [x] 🐛 Bugfix


## Issue(s)

<!-- Can reference multiple issues. Use one of the following "magic words" - "closes, fixes" to auto-close the Github issue. -->
**closes**  #966

## Test Plan
- [x]  Unit test
2022-10-19 13:41:22 +00:00
Abin Simon
17221f23d0
Drop option to build without Docker in Makefile (#1204)
## Description

Having both option could possibly lead to issues with caching.

## Type of change

<!--- Please check the type of change your PR introduces: --->
- [ ] 🌻 Feature
- [ ] 🐛 Bugfix
- [ ] 🗺️ Documentation
- [ ] 🤖 Test
- [x] 💻 CI/Deployment
- [ ] 🐹 Trivial/Minor

## Issue(s)

<!-- Can reference multiple issues. Use one of the following "magic words" - "closes, fixes" to auto-close the Github issue. -->
* #<issue>

## Test Plan

<!-- How will this be tested prior to merging.-->
- [x] 💪 Manual
- [ ]  Unit test
- [ ] 💚 E2E
2022-10-19 06:52:06 +00:00
Niraj Tolia
64c796ff18
Add git shortref to docs build (#1205)
## Description

Add git version to docs build

This will help us verify what version of docs has been published. This should be replaced by the git tag for production builds.

## Type of change

<!--- Please check the type of change your PR introduces: --->
- [x] 🌻 Feature

## Test Plan

<!-- How will this be tested prior to merging.-->
- [x] 💪 Manual
2022-10-19 06:15:55 +00:00
Niraj Tolia
7dd3b07db4
Corso docs container should be in the corso namespace (#1208)
## Description

Removes an alcion reference from the docs container

## Type of change

- [x] 🐛 Bugfix

## Test Plan

- [x] 💪 Manual
2022-10-19 06:00:43 +00:00
Abin Simon
5e5ccc1dec
Drop search in docs (#1207)
## Description

It was causing issues with building docs locally via make.
This reverts commit 4be8e825ada0b6e4d0e4372446a0f097c128896f.

## Type of change

<!--- Please check the type of change your PR introduces: --->
- [ ] 🌻 Feature
- [ ] 🐛 Bugfix
- [ ] 🗺️ Documentation
- [ ] 🤖 Test
- [ ] 💻 CI/Deployment
- [ ] 🐹 Trivial/Minor

## Issue(s)

<!-- Can reference multiple issues. Use one of the following "magic words" - "closes, fixes" to auto-close the Github issue. -->
* #<issue>

## Test Plan

<!-- How will this be tested prior to merging.-->
- [ ] 💪 Manual
- [ ]  Unit test
- [ ] 💚 E2E
2022-10-19 05:58:25 +00:00
Keepers
5d2bc1eb4e
add event production to the factory script (#1200)
## Description

Adds the capacity to programmatically generate events in the factory script.  Status is currently functional in code completion, but experiencing unexpected results.

## Type of change

- [x] 🤖 Test

## Issue(s)

* #902

## Test Plan

- [x] 💪 Manual
- [x] 💚 E2E
2022-10-18 23:54:37 +00:00
ashmrtn
28c3bbcf7a
Remove (old) unused code for fetching messages (#1168)
## Description

Just code cleanup

## Type of change

<!--- Please check the type of change your PR introduces: --->
- [ ] 🌻 Feature
- [ ] 🐛 Bugfix
- [ ] 🗺️ Documentation
- [ ] 🤖 Test
- [ ] 💻 CI/Deployment
- [x] 🐹 Trivial/Minor

## Issue(s)

* #1156

## Test Plan

<!-- How will this be tested prior to merging.-->
- [ ] 💪 Manual
- [x]  Unit test
- [ ] 💚 E2E
2022-10-18 23:09:58 +00:00
ashmrtn
0a91a3e097
Store pointer to data instead of serialized form (#1196)
## Description

Remove JSON [de]serialization from mock model store and just use assignments. Model Store tests check that all fields are properly filled out so using JSON here is not required.

Unblocks #1089 as mock model store no longer relies on JSON serialization (and tags associated with models)

## Type of change

<!--- Please check the type of change your PR introduces: --->
- [ ] 🌻 Feature
- [ ] 🐛 Bugfix
- [ ] 🗺️ Documentation
- [ ] 🤖 Test
- [ ] 💻 CI/Deployment
- [x] 🐹 Trivial/Minor

## Issue(s)

* #1085 

## Test Plan

<!-- How will this be tested prior to merging.-->
- [ ] 💪 Manual
- [x]  Unit test
- [ ] 💚 E2E
2022-10-18 20:48:08 +00:00
ashmrtn
4800904b04
Add secondary test user (#1186)
## Description

Wire up code to fetch secondary user from config/env and also provide it to tests.

## Type of change

<!--- Please check the type of change your PR introduces: --->
- [x] 🌻 Feature
- [ ] 🐛 Bugfix
- [ ] 🗺️ Documentation
- [ ] 🤖 Test
- [x] 💻 CI/Deployment
- [ ] 🐹 Trivial/Minor

## Issue(s)

* closes #1185 

merge after to ensure automatic cleanup:
* #1193 

## Test Plan

<!-- How will this be tested prior to merging.-->
- [x] 💪 Manual
- [ ]  Unit test
- [ ] 💚 E2E
2022-10-18 18:19:53 +00:00
ashmrtn
b752d1da8d
Some minor test cleanup (#1194)
## Description

* switch up email restore/backup test slightly to cover multiple folders
* remove multi-folder mail backup, now overlaps with the above
* remove stale TODO
* remove unused struct field
* factor out common struct

## Type of change

<!--- Please check the type of change your PR introduces: --->
- [ ] 🌻 Feature
- [ ] 🐛 Bugfix
- [ ] 🗺️ Documentation
- [x] 🤖 Test
- [ ] 💻 CI/Deployment
- [x] 🐹 Trivial/Minor

## Issue(s)

* #913 

## Test Plan

<!-- How will this be tested prior to merging.-->
- [ ] 💪 Manual
- [x]  Unit test
- [ ] 💚 E2E
2022-10-18 17:24:07 +00:00